hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <>
Subject [jira] Commented: (HIVE-924) Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class
Date Tue, 01 Dec 2009 21:39:20 GMT


Carl Steinbach commented on HIVE-924:

Hi Ning,

This is a really big patch that touches a lot of different files.  I don't think it is practical
to try to push it in as one big change, and consequently I have not invested time trying to
keep it in sync with trunk. If folks think these changes are worth making I was planning to
split this JIRA into several (many?) smaller JIRAs and push them in over the course of a week,
but I wanted to first give the reviewers an overview of all of the changes and final destination
I'm trying to reach.

The current patch is based on trunk@836131.  Is it possible for you to review the patch against
this tag?

Currently SemanticAnalyzer handles all DML and one DDL statement (CREATE TABLE), and DDLSemanticAnalyzer
handles the remaining DDL statements (DROP TABLE, ALTER TABLE, etc). I changed the name from
SemanticAnalyzer to DMLSemanticAnalyzer because 1) its main purpose is processing DML, and
2) I think we should try to move the CREATE TABLE code to DDLSemanticAnalyzer.

> Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class
> ------------------------------------------------------------------------
>                 Key: HIVE-924
>                 URL:
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Carl Steinbach
>         Attachments: HIVE-924.patch
> Currently the SemanticAnalyzer class handles semantic analysis, as well as logical plan
generation and physical plan generation. I think it would be beneficial to extract distinct
LogicalPlan and PhysicalPlan classes from the SemanticAnalyzer, and have the query processing
phase be coordinated by a QueryCompiler class that would be responsible for triggering the
parsing, semantic analysis, logical plan generation, optimization, and physical plan generation
phases. This proposed reorganization of components would help to isolate the state of each
phase, and would also bring the source into closer alignment with the description of the query
compiler in the Hive design document on the wiki.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message