hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <>
Subject [jira] Updated: (HIVE-726) Make "ant package -Dhadoop.version=0.17.0" work
Date Thu, 06 Aug 2009 00:59:14 GMT


Todd Lipcon updated HIVE-726:

    Attachment: hive-726.txt

I think there was still an issue which you've uncovered. ant's semantics for the <param>
element inside <antcall> are somewhat screwy - you can't override something that has
been passed on the command line. Since you guys were passing hadoop.version on the command
line, it was actually compiling the shims for 17 four times rather than compiling each version,
as best I can tell.

Attaching a patch which gets around this by introducing a new ant property called "hadoop.version.ant-internal".
This property is set in to default to hadoop.version, and hadoop.version
is left as is. Everywhere in the build files that used to reference hadoop.version now references
hadoop.version.ant-internal. Since we're not specifying this on the command line, the <antcall>s
inside shims/build.xml can properly override it.

One question: I think the condition in build.xml's eclipsefiles targets that defaults to 0.19
is now dead code, since the property itself is defaulted to 0.19.0.

Also, can we change ${} to simply ${name}-${version} since one build can work with
any hadoop?

> Make "ant package -Dhadoop.version=0.17.0" work
> -----------------------------------------------
>                 Key: HIVE-726
>                 URL:
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Build Infrastructure
>            Reporter: Zheng Shao
>         Attachments: HIVE-726.1.patch, HIVE-726.2.patch, HIVE-726.3.patch, hive-726.txt
> After HIVE-487, users will have to specify the versions as in "shims/ivy.xml" to make
"ant package -Dhadoop.version=<version>".work.
> Currently it is only running fine with the following versions (from shims/ivy.xml):,
0.18.3, 0.19.0, 0.20.0.
> We used to do "ant package -Dhadoop.version=0.17.0" but it's not working any more, although
we can specify "ant package -Dhadoop.version=" and the package will probably still
work with 0.17.0.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message