Return-Path: Delivered-To: apmail-hadoop-hive-dev-archive@minotaur.apache.org Received: (qmail 59790 invoked from network); 19 Jun 2009 01:05:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 19 Jun 2009 01:05:20 -0000 Received: (qmail 74249 invoked by uid 500); 19 Jun 2009 01:05:31 -0000 Delivered-To: apmail-hadoop-hive-dev-archive@hadoop.apache.org Received: (qmail 74219 invoked by uid 500); 19 Jun 2009 01:05:31 -0000 Mailing-List: contact hive-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hadoop.apache.org Delivered-To: mailing list hive-dev@hadoop.apache.org Received: (qmail 74177 invoked by uid 99); 19 Jun 2009 01:05:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2009 01:05:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2009 01:05:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8A2C0234C044 for ; Thu, 18 Jun 2009 18:05:07 -0700 (PDT) Message-ID: <1540877863.1245373507559.JavaMail.jira@brutus> Date: Thu, 18 Jun 2009 18:05:07 -0700 (PDT) From: "Min Zhou (JIRA)" To: hive-dev@hadoop.apache.org Subject: [jira] Commented: (HIVE-521) Move size, if, isnull, isnotnull to GenericUDF In-Reply-To: <1263272657.1243458946806.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721595#action_12721595 ] Min Zhou commented on HIVE-521: ------------------------------- ok, we are hairsplitting. passed all tests here, let commit it . +1 > Move size, if, isnull, isnotnull to GenericUDF > ---------------------------------------------- > > Key: HIVE-521 > URL: https://issues.apache.org/jira/browse/HIVE-521 > Project: Hadoop Hive > Issue Type: Improvement > Affects Versions: 0.4.0 > Reporter: Zheng Shao > Assignee: Min Zhou > Fix For: 0.4.0 > > Attachments: HIVE-521-all-v1.patch, HIVE-521-all-v2.patch, HIVE-521-all-v3.patch, HIVE-521-all-v4.patch, HIVE-521-all-v5.patch, HIVE-521-all-v6.patch, HIVE-521-all-v7.patch, HIVE-521-IF-2.patch, HIVE-521-IF-3.patch, HIVE-521-IF-4.patch, HIVE-521-IF-5.patch, HIVE-521-IF.patch > > > See HIVE-511 for an example of the move. > size, if, isnull, isnotnull are all implemented with UDF but they are actually working on variable types of objects. We should move them to GenericUDF for better type handling. > This also helps to clean up the hack in doing type matching/type conversion in UDF. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.