Return-Path: Delivered-To: apmail-hadoop-hive-dev-archive@minotaur.apache.org Received: (qmail 76453 invoked from network); 28 May 2009 09:22:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 28 May 2009 09:22:58 -0000 Received: (qmail 65816 invoked by uid 500); 28 May 2009 09:23:09 -0000 Delivered-To: apmail-hadoop-hive-dev-archive@hadoop.apache.org Received: (qmail 65664 invoked by uid 500); 28 May 2009 09:23:08 -0000 Mailing-List: contact hive-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hadoop.apache.org Delivered-To: mailing list hive-dev@hadoop.apache.org Received: (qmail 65621 invoked by uid 99); 28 May 2009 09:23:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2009 09:23:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2009 09:23:05 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 980B2234C004 for ; Thu, 28 May 2009 02:22:45 -0700 (PDT) Message-ID: <1631970486.1243502565607.JavaMail.jira@brutus> Date: Thu, 28 May 2009 02:22:45 -0700 (PDT) From: "Johan Oskarsson (JIRA)" To: hive-dev@hadoop.apache.org Subject: [jira] Updated: (HIVE-520) TestTCTLSeparatedProtocol is broken In-Reply-To: <256962738.1243443585668.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johan Oskarsson updated HIVE-520: --------------------------------- Attachment: HIVE-520.patch This patch removes the try catch block to allow the tests to fail if an unexpected exception is thrown. It also changes the various "empty string" checks to check for null values, which seems to be the current behaviour. The final piece is that internalInitialize was run twice, causing it to empty the string tokenizer and failing the tests. > TestTCTLSeparatedProtocol is broken > ----------------------------------- > > Key: HIVE-520 > URL: https://issues.apache.org/jira/browse/HIVE-520 > Project: Hadoop Hive > Issue Type: Bug > Affects Versions: 0.4.0 > Reporter: Johan Oskarsson > Priority: Critical > Fix For: 0.4.0 > > Attachments: HIVE-520.patch > > > Some of the tests in TestTCTLSeparatedProtocol throws a NullPointedException that is catched, logged and not rethrown. This means the tests don't fail even though an unexpected exception is thrown. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.