hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ser...@apache.org
Subject [25/31] hive git commit: HIVE-17313: Potentially possible 'case fall through' in the ObjectInspectorConverters (Oleg Danilov via Zoltan Haindrich)
Date Fri, 15 Sep 2017 19:52:26 GMT
HIVE-17313: Potentially possible 'case fall through' in the ObjectInspectorConverters (Oleg
Danilov via Zoltan Haindrich)

Signed-off-by: Zoltan Haindrich <kirk@rxd.hu>


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/649922d4
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/649922d4
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/649922d4

Branch: refs/heads/hive-14535
Commit: 649922d4f71a6ee81a6ca0e13cb6b7d59bbc166f
Parents: 9329cd9
Author: Oleg Danilov <oleg@olegd.com>
Authored: Fri Sep 15 09:23:22 2017 +0200
Committer: Zoltan Haindrich <kirk@rxd.hu>
Committed: Fri Sep 15 09:23:22 2017 +0200

----------------------------------------------------------------------
 .../serde2/objectinspector/ObjectInspectorConverters.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/649922d4/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
----------------------------------------------------------------------
diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
b/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
index 7921de8..cdf5ed4 100644
--- a/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
+++ b/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
@@ -111,6 +111,7 @@ public final class ObjectInspectorConverters {
         return new PrimitiveObjectInspectorConverter.StringConverter(
             inputOI);
       }
+      break;
     case CHAR:
       return new PrimitiveObjectInspectorConverter.HiveCharConverter(
           inputOI,
@@ -147,11 +148,10 @@ public final class ObjectInspectorConverters {
       return new PrimitiveObjectInspectorConverter.HiveDecimalConverter(
           inputOI,
           (SettableHiveDecimalObjectInspector) outputOI);
-    default:
-      throw new RuntimeException("Hive internal error: conversion of "
-          + inputOI.getTypeName() + " to " + outputOI.getTypeName()
-          + " not supported yet.");
     }
+    throw new RuntimeException("Hive internal error: conversion of "
+            + inputOI.getTypeName() + " to " + outputOI.getTypeName()
+            + " not supported yet.");
   }
 
   /**


Mime
View raw message