hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pv...@apache.org
Subject hive git commit: HIVE-16982: WebUI "Show Query" tab prints "UNKNOWN" instead of explaining configuration option (Karen Coppage via Peter Vary)
Date Fri, 28 Jul 2017 08:45:16 GMT
Repository: hive
Updated Branches:
  refs/heads/master 61d8b7c41 -> 52a64f14d


HIVE-16982: WebUI "Show Query" tab prints "UNKNOWN" instead of explaining configuration option
(Karen Coppage via Peter Vary)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/52a64f14
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/52a64f14
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/52a64f14

Branch: refs/heads/master
Commit: 52a64f14d5ac8c82e964ebfe64c362a7cd5ac25b
Parents: 61d8b7c
Author: Peter Vary <pvary@cloudera.com>
Authored: Fri Jul 28 10:44:26 2017 +0200
Committer: Peter Vary <pvary@cloudera.com>
Committed: Fri Jul 28 10:44:26 2017 +0200

----------------------------------------------------------------------
 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java | 3 ++-
 ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java   | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/52a64f14/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
----------------------------------------------------------------------
diff --git a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
index 05f6cc9..20b193c 100644
--- a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
+++ b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
@@ -2256,7 +2256,8 @@ public class HiveConf extends Configuration {
 
     HIVE_LOG_EXPLAIN_OUTPUT("hive.log.explain.output", false,
         "Whether to log explain output for every query.\n" +
-        "When enabled, will log EXPLAIN EXTENDED output for the query at INFO log4j log level."),
+        "When enabled, will log EXPLAIN EXTENDED output for the query at INFO log4j log level\n"
+
+        "and in WebUI / Drilldown / Show Query."),
     HIVE_EXPLAIN_USER("hive.explain.user", true,
         "Whether to show explain result at user level.\n" +
         "When enabled, will log EXPLAIN output for the query at user level. Tez only."),

http://git-wip-us.apache.org/repos/asf/hive/blob/52a64f14/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java b/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
index bf6cb91..5bf2210 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
@@ -207,7 +207,7 @@ public class QueryDisplay {
   }
 
   public synchronized String getExplainPlan() {
-    return returnStringOrUnknown(explainPlan);
+    return explainPlan == null ? "SET hive.log.explain.output TO true TO VIEW PLANS" : explainPlan;
   }
 
   public synchronized void setExplainPlan(String explainPlan) {


Mime
View raw message