hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ser...@apache.org
Subject hive git commit: HIVE-16987 : Llap: StackOverFlow in EvictionDispatcher:notifyEvicted (Sergey Shelhukhin, reviewed by Rajesh Balamohan)
Date Thu, 29 Jun 2017 17:29:30 GMT
Repository: hive
Updated Branches:
  refs/heads/master 10944ee34 -> 0f2800452


HIVE-16987 : Llap: StackOverFlow in EvictionDispatcher:notifyEvicted (Sergey Shelhukhin, reviewed
by Rajesh Balamohan)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/0f280045
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/0f280045
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/0f280045

Branch: refs/heads/master
Commit: 0f2800452a35133511bf993c9178f43a293756ad
Parents: 10944ee
Author: sergey <sershe@apache.org>
Authored: Thu Jun 29 10:29:14 2017 -0700
Committer: sergey <sershe@apache.org>
Committed: Thu Jun 29 10:29:14 2017 -0700

----------------------------------------------------------------------
 .../hadoop/hive/llap/cache/EvictionDispatcher.java      | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/0f280045/llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java
----------------------------------------------------------------------
diff --git a/llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java
b/llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java
index c73f1a1..0cbc8f6 100644
--- a/llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java
+++ b/llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java
@@ -17,6 +17,7 @@
  */
 package org.apache.hadoop.hive.llap.cache;
 
+import org.apache.hadoop.hive.llap.cache.SerDeLowLevelCacheImpl.LlapSerDeDataBuffer;
 import org.apache.hadoop.hive.llap.io.metadata.OrcFileEstimateErrors;
 import org.apache.hadoop.hive.llap.io.metadata.OrcFileMetadata;
 import org.apache.hadoop.hive.llap.io.metadata.OrcMetadataCache;
@@ -44,13 +45,14 @@ public final class EvictionDispatcher implements EvictionListener, LlapOomDebugD
     buffer.notifyEvicted(this); // This will call one of the specific notifyEvicted overloads.
   }
 
+  public void notifyEvicted(LlapSerDeDataBuffer buffer) {
+    serdeCache.notifyEvicted(buffer);
+    allocator.deallocateEvicted(buffer);
+   
+  }
+
   public void notifyEvicted(LlapDataBuffer buffer) {
-    // Note: we don't know which cache this is from, so we notify both. They can noop if
they
-    //       want to find the buffer in their structures and can't.
     dataCache.notifyEvicted(buffer);
-    if (serdeCache != null) {
-      serdeCache.notifyEvicted(buffer);
-    }
     allocator.deallocateEvicted(buffer);
   }
 


Mime
View raw message