hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ser...@apache.org
Subject [43/44] hive git commit: HIVE-14865 Fix comments after HIVE-14350 (Eugene Koifman, reviewed by Alan Gates)
Date Sat, 01 Oct 2016 01:09:25 GMT
HIVE-14865 Fix comments after HIVE-14350 (Eugene Koifman, reviewed by Alan Gates)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/297b4433
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/297b4433
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/297b4433

Branch: refs/heads/hive-14535
Commit: 297b4433cd2fdfb84182668bf7b1c524e92c6593
Parents: f903c4a
Author: Eugene Koifman <ekoifman@hortonworks.com>
Authored: Fri Sep 30 15:10:23 2016 -0700
Committer: Eugene Koifman <ekoifman@hortonworks.com>
Committed: Fri Sep 30 15:10:23 2016 -0700

----------------------------------------------------------------------
 ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java | 6 ------
 1 file changed, 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/297b4433/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java b/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
index cda5f39..f1eba5d 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
@@ -866,7 +866,6 @@ public class AcidUtils {
        * {@link txnList}.  Note that 'original' files are logically a base_Long.MIN_VALUE
and thus
        * cannot have any data for an open txn.  We could check {@link deltas} has files to
cover
        * [1,n] w/o gaps but this would almost never happen...*/
-      //todo: this should only care about 'open' tnxs (HIVE-14211)
       long[] exceptions = txnList.getInvalidTransactions();
       String minOpenTxn = exceptions != null && exceptions.length > 0 ?
         Long.toString(exceptions[0]) : "x";
@@ -910,11 +909,6 @@ public class AcidUtils {
    * files within the snapshot.
    */
   private static boolean isValidBase(long baseTxnId, ValidTxnList txnList) {
-    /*This implementation is suboptimal.  It considers open/aborted txns invalid while we
are only
-    * concerned with 'open' ones.  (Compaction removes any data that belongs to aborted txns
and
-    * reads skip anything that belongs to aborted txn, thus base_7 is still OK if the only
exception
-    * is txn 5 which is aborted).  So this implementation can generate false positives. (HIVE-14211)
-    * */
     if(baseTxnId == Long.MIN_VALUE) {
       //such base is created by 1st compaction in case of non-acid to acid table conversion
       //By definition there are no open txns with id < 1.


Mime
View raw message