Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5F266200B88 for ; Thu, 8 Sep 2016 04:19:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5DB66160ACF; Thu, 8 Sep 2016 02:19:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A66F3160AC1 for ; Thu, 8 Sep 2016 04:19:20 +0200 (CEST) Received: (qmail 71530 invoked by uid 500); 8 Sep 2016 02:19:19 -0000 Mailing-List: contact commits-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hive.apache.org Delivered-To: mailing list commits@hive.apache.org Received: (qmail 71519 invoked by uid 99); 8 Sep 2016 02:19:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2016 02:19:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9D87AE01BD; Thu, 8 Sep 2016 02:19:19 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: xuf@apache.org To: commits@hive.apache.org Message-Id: <240df2dba3984bd582df7298e43e3942@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hive git commit: Revert "HIVE-13589: beeline - support prompt for password with '-u' option(Ke Jia, reviewed by Vihang Karajgaonkar and Ferdinand Xu)" Date: Thu, 8 Sep 2016 02:19:19 +0000 (UTC) archived-at: Thu, 08 Sep 2016 02:19:21 -0000 Repository: hive Updated Branches: refs/heads/master 8cec20d97 -> 63fdb513f Revert "HIVE-13589: beeline - support prompt for password with '-u' option(Ke Jia, reviewed by Vihang Karajgaonkar and Ferdinand Xu)" This reverts commit e6b5115868ca42f974e525d2309e747be65f5d80. Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/63fdb513 Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/63fdb513 Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/63fdb513 Branch: refs/heads/master Commit: 63fdb513f907309b4de4122ea5e37f17da7e0f7b Parents: 8cec20d Author: Ferdinand Xu Authored: Thu Sep 8 02:50:40 2016 +0800 Committer: Ferdinand Xu Committed: Thu Sep 8 02:50:40 2016 +0800 ---------------------------------------------------------------------- .../src/java/org/apache/hive/beeline/BeeLine.java | 15 ++++++--------- .../src/java/org/apache/hive/beeline/Commands.java | 2 +- 2 files changed, 7 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/63fdb513/beeline/src/java/org/apache/hive/beeline/BeeLine.java ---------------------------------------------------------------------- diff --git a/beeline/src/java/org/apache/hive/beeline/BeeLine.java b/beeline/src/java/org/apache/hive/beeline/BeeLine.java index 8e65e39..ecd60f6 100644 --- a/beeline/src/java/org/apache/hive/beeline/BeeLine.java +++ b/beeline/src/java/org/apache/hive/beeline/BeeLine.java @@ -881,7 +881,6 @@ public class BeeLine implements Closeable { } try { - ConsoleReader reader = getConsoleReader(inputStream); if (isBeeLine) { int code = initArgs(args); if (code != 0) { @@ -906,7 +905,7 @@ public class BeeLine implements Closeable { } catch (Exception e) { // ignore } - + ConsoleReader reader = getConsoleReader(inputStream); return execute(reader, false); } finally { close(); @@ -1080,16 +1079,14 @@ public class BeeLine implements Closeable { Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() { @Override public void run() { - if(consoleReader != null) { History h = consoleReader.getHistory(); if (h instanceof FileHistory) { - try { - ((FileHistory) h).flush(); - } catch (IOException e) { - error(e); - } + try { + ((FileHistory) h).flush(); + } catch (IOException e) { + error(e); + } } - } } })); http://git-wip-us.apache.org/repos/asf/hive/blob/63fdb513/beeline/src/java/org/apache/hive/beeline/Commands.java ---------------------------------------------------------------------- diff --git a/beeline/src/java/org/apache/hive/beeline/Commands.java b/beeline/src/java/org/apache/hive/beeline/Commands.java index 2f3ec13..039e354 100644 --- a/beeline/src/java/org/apache/hive/beeline/Commands.java +++ b/beeline/src/java/org/apache/hive/beeline/Commands.java @@ -1511,7 +1511,7 @@ public class Commands { username = beeLine.getConsoleReader().readLine("Enter username for " + url + ": "); } props.setProperty(JdbcConnectionParams.AUTH_USER, username); - if (password == null || password.length() == 0) { + if (password == null) { password = beeLine.getConsoleReader().readLine("Enter password for " + url + ": ", new Character('*')); }