Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0F262200B63 for ; Mon, 15 Aug 2016 23:28:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0DC46160AA7; Mon, 15 Aug 2016 21:28:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 56748160A8A for ; Mon, 15 Aug 2016 23:28:42 +0200 (CEST) Received: (qmail 129 invoked by uid 500); 15 Aug 2016 21:28:41 -0000 Mailing-List: contact commits-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hive.apache.org Delivered-To: mailing list commits@hive.apache.org Received: (qmail 118 invoked by uid 99); 15 Aug 2016 21:28:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 21:28:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 49886E0100; Mon, 15 Aug 2016 21:28:41 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: prasanthj@apache.org To: commits@hive.apache.org Message-Id: <06c79a7adb2f481d8ffea6ddf1604e6c@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hive git commit: HIVE-14533: improve performance of enforceMaxLength in HiveCharWritable/HiveVarcharWritable (Thomas Friedrich reviewed by Prasanth Jayachandran) Date: Mon, 15 Aug 2016 21:28:41 +0000 (UTC) archived-at: Mon, 15 Aug 2016 21:28:43 -0000 Repository: hive Updated Branches: refs/heads/master 653b85899 -> fb86e89a1 HIVE-14533: improve performance of enforceMaxLength in HiveCharWritable/HiveVarcharWritable (Thomas Friedrich reviewed by Prasanth Jayachandran) Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/fb86e89a Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/fb86e89a Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/fb86e89a Branch: refs/heads/master Commit: fb86e89a15db784fb60d090a50562cdb5776786a Parents: 653b858 Author: Prasanth Jayachandran Authored: Mon Aug 15 14:28:29 2016 -0700 Committer: Prasanth Jayachandran Committed: Mon Aug 15 14:28:29 2016 -0700 ---------------------------------------------------------------------- .../java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java | 3 ++- .../org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/fb86e89a/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java ---------------------------------------------------------------------- diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java b/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java index 2aaa90c..2236a87 100644 --- a/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java +++ b/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java @@ -73,7 +73,8 @@ public class HiveCharWritable extends HiveBaseCharWritable } public void enforceMaxLength(int maxLength) { - set(getHiveChar(), maxLength); + if (getCharacterLength()!=maxLength) + set(getHiveChar(), maxLength); } public Text getStrippedValue() { http://git-wip-us.apache.org/repos/asf/hive/blob/fb86e89a/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java ---------------------------------------------------------------------- diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java b/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java index 2e24730..ae53bec 100644 --- a/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java +++ b/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java @@ -65,7 +65,8 @@ public class HiveVarcharWritable extends HiveBaseCharWritable public void enforceMaxLength(int maxLength) { // Might be possible to truncate the existing Text value, for now just do something simple. - set(getHiveVarchar(), maxLength); + if (value.getLength()>maxLength && getCharacterLength()>maxLength) + set(getHiveVarchar(), maxLength); } @Override