hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ekoif...@apache.org
Subject hive git commit: HIVE-13912 DbTxnManager.commitTxn(): ORA-00918: column ambiguously defined (Eugene Koifman, reviewed by Alan Gates)
Date Mon, 06 Jun 2016 21:13:31 GMT
Repository: hive
Updated Branches:
  refs/heads/branch-1 ad244efe4 -> 1d2725a8c


HIVE-13912 DbTxnManager.commitTxn(): ORA-00918: column ambiguously defined (Eugene Koifman,
reviewed by Alan Gates)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/1d2725a8
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/1d2725a8
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/1d2725a8

Branch: refs/heads/branch-1
Commit: 1d2725a8cbca4dff21e6a28081472e77d0a3db4e
Parents: ad244ef
Author: Eugene Koifman <ekoifman@hortonworks.com>
Authored: Mon Jun 6 14:13:25 2016 -0700
Committer: Eugene Koifman <ekoifman@hortonworks.com>
Committed: Mon Jun 6 14:13:25 2016 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/1d2725a8/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
----------------------------------------------------------------------
diff --git a/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java b/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
index 954aaf6..129abef 100644
--- a/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
+++ b/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
@@ -650,7 +650,7 @@ abstract class TxnHandler implements TxnStore, TxnStore.MutexAPI {
            */
           rs = stmt.executeQuery
             (sqlGenerator.addLimitClause(1, "committed.ws_txnid, committed.ws_commit_id,
committed.ws_database," +
-              "committed.ws_table, committed.ws_partition, cur.ws_commit_id " +
+              "committed.ws_table, committed.ws_partition, cur.ws_commit_id cur_ws_commit_id
" +
               "from WRITE_SET committed INNER JOIN WRITE_SET cur " +
               "ON committed.ws_database=cur.ws_database and committed.ws_table=cur.ws_table
" +
               //For partitioned table we always track writes at partition level (never at
table)
@@ -3417,6 +3417,9 @@ abstract class TxnHandler implements TxnStore, TxnStore.MutexAPI {
      * to the first 5 rows.  The mechanism to do that differs in different DB.
      * Make {@code noSelectsqlQuery} to be "a,b from T" and this method will return the
      * appropriately modified row limiting query.
+     *
+     * Note that if {@code noSelectsqlQuery} contains a join, you must make sure that
+     * all columns are unique for Oracle.
      */
     private String addLimitClause(int numRows, String noSelectsqlQuery) throws MetaException
{
       switch (dbProduct) {


Mime
View raw message