hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From da...@apache.org
Subject hive git commit: HIVE-12279: Testcase to verify session temporary files are removed after HIVE-11768
Date Wed, 25 May 2016 22:45:25 GMT
Repository: hive
Updated Branches:
  refs/heads/master 134288452 -> d2dac26df


HIVE-12279: Testcase to verify session temporary files are removed after HIVE-11768


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/d2dac26d
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/d2dac26d
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/d2dac26d

Branch: refs/heads/master
Commit: d2dac26dfa7a93fb15fae08a4eaff923495d287b
Parents: 1342884
Author: Daniel Dai <daijy@hortonworks.com>
Authored: Wed May 25 15:44:32 2016 -0700
Committer: Daniel Dai <daijy@hortonworks.com>
Committed: Wed May 25 15:44:32 2016 -0700

----------------------------------------------------------------------
 .../service/cli/session/TestSessionCleanup.java | 77 ++++++++++++++++++++
 1 file changed, 77 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/d2dac26d/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java
----------------------------------------------------------------------
diff --git a/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java
b/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java
new file mode 100644
index 0000000..e38a52a
--- /dev/null
+++ b/service/src/test/org/apache/hive/service/cli/session/TestSessionCleanup.java
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.service.cli.session;
+
+import java.io.File;
+import java.io.FilenameFilter;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+import junit.framework.TestCase;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
+import org.apache.hive.service.cli.SessionHandle;
+import org.apache.hive.service.cli.thrift.EmbeddedThriftBinaryCLIService;
+import org.apache.hive.service.cli.thrift.ThriftCLIServiceClient;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestSessionCleanup extends TestCase {
+
+  @Test
+  // This is to test session temporary files are cleaned up after HIVE-11768
+  public void testTempSessionFileCleanup() throws Exception {
+    EmbeddedThriftBinaryCLIService service = new EmbeddedThriftBinaryCLIService();
+    service.init(null);
+    ThriftCLIServiceClient client = new ThriftCLIServiceClient(service);
+
+    Set<String> existingPipeoutFiles = new HashSet<String>(Arrays.asList(getPipeoutFiles()));
+    SessionHandle sessionHandle = client.openSession("user1", "foobar",
+          Collections.<String, String>emptyMap());
+    client.executeStatement(sessionHandle, "set a=b", null);
+    File operationLogRootDir = new File(
+        new HiveConf().getVar(ConfVars.HIVE_SERVER2_LOGGING_OPERATION_LOG_LOCATION));
+    Assert.assertNotEquals(operationLogRootDir.list().length, 0);
+    client.closeSession(sessionHandle);
+
+    // Check if session files are removed
+    Assert.assertEquals(operationLogRootDir.list().length, 0);
+
+    // Check if the pipeout files are removed
+    Set<String> finalPipeoutFiles = new HashSet<String>(Arrays.asList(getPipeoutFiles()));
+    finalPipeoutFiles.removeAll(existingPipeoutFiles);
+    Assert.assertTrue(finalPipeoutFiles.isEmpty());
+  }
+
+  private String[] getPipeoutFiles() {
+    File localScratchDir = new File(
+        new HiveConf().getVar(HiveConf.ConfVars.LOCALSCRATCHDIR));
+    String[] pipeoutFiles = localScratchDir.list(new FilenameFilter() {
+      @Override
+      public boolean accept(File dir, String name) {
+        if (name.endsWith("pipeout")) return true;
+        return false;
+      }
+    });
+    return pipeoutFiles;
+  }
+}


Mime
View raw message