Return-Path: X-Original-To: apmail-hive-commits-archive@www.apache.org Delivered-To: apmail-hive-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2623711612 for ; Wed, 6 Aug 2014 21:35:07 +0000 (UTC) Received: (qmail 83671 invoked by uid 500); 6 Aug 2014 21:35:06 -0000 Delivered-To: apmail-hive-commits-archive@hive.apache.org Received: (qmail 83633 invoked by uid 500); 6 Aug 2014 21:35:06 -0000 Mailing-List: contact commits-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hive.apache.org Delivered-To: mailing list commits@hive.apache.org Received: (qmail 83622 invoked by uid 99); 6 Aug 2014 21:35:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2014 21:35:06 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2014 21:35:05 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 761AD2389343; Wed, 6 Aug 2014 21:34:45 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1616357 - /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java Date: Wed, 06 Aug 2014 21:34:45 -0000 To: commits@hive.apache.org From: sershe@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140806213445.761AD2389343@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sershe Date: Wed Aug 6 21:34:45 2014 New Revision: 1616357 URL: http://svn.apache.org/r1616357 Log: HIVE-7574 : CommonJoinOperator.checkAndGenObject calls LOG.Trace per row from probe side in a HashMap join consuming 4% of the CPU (Mostafa Mokhtar, reviewed by Sergey Shelukhin) Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java?rev=1616357&r1=1616356&r2=1616357&view=diff ============================================================================== --- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java (original) +++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java Wed Aug 6 21:34:45 2014 @@ -705,13 +705,9 @@ public abstract class CommonJoinOperator } if (allOne) { - LOG.info("calling genAllOneUniqueJoinObject"); genAllOneUniqueJoinObject(); - LOG.info("called genAllOneUniqueJoinObject"); } else { - LOG.trace("calling genUniqueJoinObject"); genUniqueJoinObject(0, 0); - LOG.trace("called genUniqueJoinObject"); } } else { // does any result need to be emitted @@ -753,17 +749,11 @@ public abstract class CommonJoinOperator } if (!hasEmpty && !mayHasMoreThanOne) { - LOG.trace("calling genAllOneUniqueJoinObject"); genAllOneUniqueJoinObject(); - LOG.trace("called genAllOneUniqueJoinObject"); } else if (!hasEmpty && !hasLeftSemiJoin) { - LOG.trace("calling genUniqueJoinObject"); genUniqueJoinObject(0, 0); - LOG.trace("called genUniqueJoinObject"); } else { - LOG.trace("calling genObject"); genJoinObject(); - LOG.trace("called genObject"); } } Arrays.fill(aliasFilterTags, (byte)0xff);