hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gunt...@apache.org
Subject svn commit: r1556628 - in /hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql: exec/tez/TezSessionState.java optimizer/ConvertJoinMapJoin.java optimizer/ReduceSinkMapJoinProc.java plan/PlanUtils.java stats/CounterStatsAggregatorTez.java
Date Wed, 08 Jan 2014 20:38:45 GMT
Author: gunther
Date: Wed Jan  8 20:38:45 2014
New Revision: 1556628

URL: http://svn.apache.org/r1556628
Log:
HIVE-6168: Fix some javadoc issues on Tez branch (Gunther Hagleitner)

Modified:
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java?rev=1556628&r1=1556627&r2=1556628&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
(original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Wed Jan  8 20:38:45 2014
@@ -147,6 +147,7 @@ public class TezSessionState {
   /**
    * Close a tez session. Will cleanup any tez/am related resources. After closing a session
    * no further DAGs can be executed against it.
+   * @param keepTmpDir whether or not to remove the scratch dir at the same time.
    * @throws IOException
    * @throws TezException
    */
@@ -212,7 +213,6 @@ public class TezSessionState {
   /**
    * Returns a local resource representing the hive-exec jar. This resource will
    * be used to execute the plan on the cluster.
-   * @param conf
    * @return LocalResource corresponding to the localized hive exec resource.
    * @throws IOException when any file system related call fails.
    * @throws LoginException when we are unable to determine the user.

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java?rev=1556628&r1=1556627&r2=1556628&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
(original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
Wed Jan  8 20:38:45 2014
@@ -39,7 +39,7 @@ import org.apache.hadoop.hive.ql.plan.Op
 import org.apache.hadoop.hive.ql.plan.Statistics;
 
 /**
- * ConvertJoinMapJoin is an optimization that replaces a commone join
+ * ConvertJoinMapJoin is an optimization that replaces a common join
  * (aka shuffle join) with a map join (aka broadcast or fragment replicate
  * join when possible. Map joins have restrictions on which joins can be
  * converted (e.g.: full outer joins cannot be handled as map joins) as well

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java?rev=1556628&r1=1556627&r2=1556628&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java
(original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java
Wed Jan  8 20:38:45 2014
@@ -34,8 +34,8 @@ public class ReduceSinkMapJoinProc imple
 
   /* (non-Javadoc)
    * This processor addresses the RS-MJ case that occurs in tez on the small/hash
-   * table side of things. The connection between the work that RS will be a part of
-   * must be connected to the MJ work via be a broadcast edge.
+   * table side of things. The work that RS will be a part of must be connected 
+   * to the MJ work via be a broadcast edge.
    * We should not walk down the tree when we encounter this pattern because:
    * the type of work (map work or reduce work) needs to be determined
    * on the basis of the big table side because it may be a mapwork (no need for shuffle)

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java?rev=1556628&r1=1556627&r2=1556628&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java (original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java Wed Jan  8
20:38:45 2014
@@ -419,7 +419,7 @@ public final class PlanUtils {
   }
 
   /**
-   * Generate the table descriptor for Map-side join key.
+   * Generate the table descriptor for Map-side join value.
    */
   public static TableDesc getMapJoinValueTableDesc(
       List<FieldSchema> fieldSchemas) {

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java?rev=1556628&r1=1556627&r2=1556628&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java
(original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java
Wed Jan  8 20:38:45 2014
@@ -27,6 +27,12 @@ import org.apache.hadoop.hive.ql.exec.Ta
 import org.apache.hadoop.hive.ql.exec.tez.TezTask;
 import org.apache.tez.common.counters.TezCounters;
 
+/**
+ * This class aggregates stats via counters and does so for Tez Tasks.
+ * With dbclass=counters this class will compute table/partition statistics
+ * using hadoop counters. They will be published using special keys and
+ * then retrieved on the client after the insert/ctas statement ran.
+ */
 public class CounterStatsAggregatorTez implements StatsAggregator {
 
   private static final Log LOG = LogFactory.getLog(CounterStatsAggregatorTez.class.getName());



Mime
View raw message