Return-Path: X-Original-To: apmail-hive-commits-archive@www.apache.org Delivered-To: apmail-hive-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8391F10BD9 for ; Wed, 27 Nov 2013 16:22:06 +0000 (UTC) Received: (qmail 50309 invoked by uid 500); 27 Nov 2013 16:21:23 -0000 Delivered-To: apmail-hive-commits-archive@hive.apache.org Received: (qmail 50243 invoked by uid 500); 27 Nov 2013 16:21:14 -0000 Mailing-List: contact commits-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hive.apache.org Delivered-To: mailing list commits@hive.apache.org Received: (qmail 50221 invoked by uid 99); 27 Nov 2013 16:21:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2013 16:21:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2013 16:21:06 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 2FA42238883D; Wed, 27 Nov 2013 16:20:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1546089 - in /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec: FileSinkOperator.java JobCloseFeedBack.java JoinOperator.java Operator.java mr/ExecDriver.java Date: Wed, 27 Nov 2013 16:20:44 -0000 To: commits@hive.apache.org From: hashutosh@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131127162044.2FA42238883D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: hashutosh Date: Wed Nov 27 16:20:43 2013 New Revision: 1546089 URL: http://svn.apache.org/r1546089 Log: HIVE-5886 : [Refactor] Remove unused class JobCloseFeedback (Ashutosh Chauhan via Thejas Nair) Removed: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JobCloseFeedBack.java Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java?rev=1546089&r1=1546088&r2=1546089&view=diff ============================================================================== --- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java (original) +++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java Wed Nov 27 16:20:43 2013 @@ -878,7 +878,7 @@ public class FileSinkOperator extends Te } @Override - public void jobCloseOp(Configuration hconf, boolean success, JobCloseFeedBack feedBack) + public void jobCloseOp(Configuration hconf, boolean success) throws HiveException { try { if ((conf != null) && isNativeTable) { @@ -893,7 +893,7 @@ public class FileSinkOperator extends Te } catch (IOException e) { throw new HiveException(e); } - super.jobCloseOp(hconf, success, feedBack); + super.jobCloseOp(hconf, success); } @Override Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java?rev=1546089&r1=1546088&r2=1546089&view=diff ============================================================================== --- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java (original) +++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java Wed Nov 27 16:20:43 2013 @@ -144,7 +144,7 @@ public class JoinOperator extends Common } @Override - public void jobCloseOp(Configuration hconf, boolean success, JobCloseFeedBack feedBack) + public void jobCloseOp(Configuration hconf, boolean success) throws HiveException { int numAliases = conf.getExprs().size(); if (conf.getHandleSkewJoin()) { @@ -181,7 +181,7 @@ public class JoinOperator extends Common throw new HiveException(e); } } - super.jobCloseOp(hconf, success, feedBack); + super.jobCloseOp(hconf, success); } private void moveUpFiles(String specPath, Configuration hconf, Log log) Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java?rev=1546089&r1=1546088&r2=1546089&view=diff ============================================================================== --- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java (original) +++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java Wed Nov 27 16:20:43 2013 @@ -571,7 +571,7 @@ public abstract class Operator op : childOperators) { - op.jobClose(conf, success, feedBack); + op.jobClose(conf, success); } } } Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java?rev=1546089&r1=1546088&r2=1546089&view=diff ============================================================================== --- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java (original) +++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java Wed Nov 27 16:20:43 2013 @@ -50,7 +50,6 @@ import org.apache.hadoop.hive.ql.ErrorMs import org.apache.hadoop.hive.ql.QueryPlan; import org.apache.hadoop.hive.ql.exec.FetchOperator; import org.apache.hadoop.hive.ql.exec.HiveTotalOrderPartitioner; -import org.apache.hadoop.hive.ql.exec.JobCloseFeedBack; import org.apache.hadoop.hive.ql.exec.Operator; import org.apache.hadoop.hive.ql.exec.OperatorUtils; import org.apache.hadoop.hive.ql.exec.PartitionKeySampler; @@ -466,14 +465,13 @@ public class ExecDriver extends Task op : mWork.getAliasToWork().values()) { - op.jobClose(job, success, feedBack); + op.jobClose(job, success); } } if (rWork != null) { - rWork.getReducer().jobClose(job, success, feedBack); + rWork.getReducer().jobClose(job, success); } } } catch (Exception e) {