hive-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gunt...@apache.org
Subject svn commit: r1537799 - in /hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql: io/orc/OrcInputFormat.java io/orc/ReaderImpl.java log/PerfLogger.java
Date Fri, 01 Nov 2013 01:16:12 GMT
Author: gunther
Date: Fri Nov  1 01:16:12 2013
New Revision: 1537799

URL: http://svn.apache.org/r1537799
Log:
HIVE-5719: Remove some overly noisy perflogger statements from Tez codepath (Gunther Hagleitner)

Modified:
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java
    hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java?rev=1537799&r1=1537798&r2=1537799&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java Fri
Nov  1 01:16:12 2013
@@ -43,6 +43,8 @@ import org.apache.hadoop.hive.ql.exec.Ut
 import org.apache.hadoop.hive.ql.exec.vector.VectorizedInputFormatInterface;
 import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
 import org.apache.hadoop.hive.ql.io.InputFormatChecker;
+import org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.FileGenerator;
+import org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.SplitGenerator;
 import org.apache.hadoop.hive.ql.io.orc.Reader.FileMetaInfo;
 import org.apache.hadoop.hive.ql.io.sarg.SearchArgument;
 import org.apache.hadoop.hive.ql.log.PerfLogger;
@@ -457,7 +459,6 @@ public class OrcInputFormat  implements 
     @Override
     public void run() {
       try {
-        perfLogger.PerfLogBegin(CLASS_NAME, PerfLogger.ORC_GET_BLOCK_LOCATIONS);
         Iterator<FileStatus> itr = context.shims.listLocatedStatus(fs, dir,
             hiddenFileFilter);
         while (itr.hasNext()) {
@@ -470,8 +471,6 @@ public class OrcInputFormat  implements 
             context.schedule(new SplitGenerator(context, fs, file, fileInfo));
           }
         }
-        // mark the fact that we are done
-        perfLogger.PerfLogEnd(CLASS_NAME, PerfLogger.ORC_GET_BLOCK_LOCATIONS);
       } catch (Throwable th) {
         if (!(th instanceof IOException)) {
           LOG.error("Unexpected Exception", th);
@@ -634,7 +633,6 @@ public class OrcInputFormat  implements 
      */
     @Override
     public void run() {
-      perfLogger.PerfLogBegin(CLASS_NAME, PerfLogger.CREATE_ORC_SPLITS);
       try {
         populateAndCacheStripeDetails();
         long currentOffset = -1;
@@ -675,7 +673,6 @@ public class OrcInputFormat  implements 
       } finally {
         context.decrementSchedulers();
       }
-      perfLogger.PerfLogEnd(CLASS_NAME, PerfLogger.CREATE_ORC_SPLITS);
     }
 
 

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java?rev=1537799&r1=1537798&r2=1537799&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java (original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java Fri Nov
 1 01:16:12 2013
@@ -288,7 +288,6 @@ final class ReaderImpl implements Reader
    * @throws IOException
    */
   ReaderImpl(FileSystem fs, Path path) throws IOException {
-    perfLogger.PerfLogBegin(CLASS_NAME, PerfLogger.INIT_ORC_RECORD_READER);
     this.fileSystem = fs;
     this.path = path;
 
@@ -303,7 +302,6 @@ final class ReaderImpl implements Reader
     this.bufferSize = rInfo.bufferSize;
     this.footer = rInfo.footer;
     this.inspector = rInfo.inspector;
-    perfLogger.PerfLogEnd(CLASS_NAME, PerfLogger.INIT_ORC_RECORD_READER);
   }
 
 
@@ -317,7 +315,6 @@ final class ReaderImpl implements Reader
    */
   ReaderImpl(FileSystem fs, Path path, FileMetaInfo fMetaInfo)
       throws IOException {
-    perfLogger.PerfLogBegin(CLASS_NAME, PerfLogger.INIT_ORC_RECORD_READER);
     this.fileSystem = fs;
     this.path = path;
 
@@ -332,8 +329,6 @@ final class ReaderImpl implements Reader
     this.bufferSize = rInfo.bufferSize;
     this.footer = rInfo.footer;
     this.inspector = rInfo.inspector;
-    perfLogger.PerfLogEnd(CLASS_NAME, PerfLogger.INIT_ORC_RECORD_READER);
-
   }
 
 

Modified: hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
URL: http://svn.apache.org/viewvc/hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java?rev=1537799&r1=1537798&r2=1537799&view=diff
==============================================================================
--- hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java (original)
+++ hive/branches/tez/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java Fri Nov  1
01:16:12 2013
@@ -63,10 +63,7 @@ public class PerfLogger {
   public static final String TEZ_RUN_PROCESSOR = "TezRunProcessor";
   public static final String TEZ_INIT_OPERATORS = "TezInitializeOperators";
   public static final String LOAD_HASHTABLE = "LoadHashtable";
-  public static final String INIT_ORC_RECORD_READER = "OrcRecordReaderInit";
-  public static final String CREATE_ORC_SPLITS = "OrcCreateSplits";
   public static final String ORC_GET_SPLITS = "OrcGetSplits";
-  public static final String ORC_GET_BLOCK_LOCATIONS = "OrcGetBlockLocations";
 
   protected static final ThreadLocal<PerfLogger> perfLogger = new ThreadLocal<PerfLogger>();
 



Mime
View raw message