Return-Path: X-Original-To: apmail-hive-commits-archive@www.apache.org Delivered-To: apmail-hive-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20A9591A0 for ; Mon, 2 Jul 2012 08:36:36 +0000 (UTC) Received: (qmail 30745 invoked by uid 500); 2 Jul 2012 08:36:36 -0000 Delivered-To: apmail-hive-commits-archive@hive.apache.org Received: (qmail 30546 invoked by uid 500); 2 Jul 2012 08:36:32 -0000 Mailing-List: contact commits-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hive.apache.org Delivered-To: mailing list commits@hive.apache.org Received: (qmail 30495 invoked by uid 99); 2 Jul 2012 08:36:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2012 08:36:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2012 08:36:28 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id A0D842388AA7 for ; Mon, 2 Jul 2012 08:36:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1356108 - /hive/trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java Date: Mon, 02 Jul 2012 08:36:07 -0000 To: commits@hive.apache.org From: hashutosh@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120702083607.A0D842388AA7@eris.apache.org> Author: hashutosh Date: Mon Jul 2 08:36:06 2012 New Revision: 1356108 URL: http://svn.apache.org/viewvc?rev=1356108&view=rev Log: HIVE-3207 : FileUtils.tar does not close input files (Navis Ryu via Ashutosh Chauhan) Modified: hive/trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java Modified: hive/trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java URL: http://svn.apache.org/viewvc/hive/trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java?rev=1356108&r1=1356107&r2=1356108&view=diff ============================================================================== --- hive/trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java (original) +++ hive/trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java Mon Jul 2 08:36:06 2012 @@ -267,7 +267,12 @@ public final class FileUtils { TarArchiveEntry tarEntry = new TarArchiveEntry(f, f.getName()); tOut.setLongFileMode(TarArchiveOutputStream.LONGFILE_GNU); tOut.putArchiveEntry(tarEntry); - IOUtils.copy(new FileInputStream(f), tOut); // copy with 8K buffer, not close + FileInputStream input = new FileInputStream(f); + try { + IOUtils.copy(input, tOut); // copy with 8K buffer, not close + } finally { + input.close(); + } tOut.closeArchiveEntry(); } tOut.close(); // finishes inside