Return-Path: X-Original-To: apmail-hive-commits-archive@www.apache.org Delivered-To: apmail-hive-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9FD8B95B3 for ; Fri, 2 Dec 2011 21:28:02 +0000 (UTC) Received: (qmail 54354 invoked by uid 500); 2 Dec 2011 21:28:02 -0000 Delivered-To: apmail-hive-commits-archive@hive.apache.org Received: (qmail 54316 invoked by uid 500); 2 Dec 2011 21:28:02 -0000 Mailing-List: contact commits-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hive.apache.org Delivered-To: mailing list commits@hive.apache.org Received: (qmail 54308 invoked by uid 99); 2 Dec 2011 21:28:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2011 21:28:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2011 21:27:59 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 89C2023888E7 for ; Fri, 2 Dec 2011 21:27:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1209696 - /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java Date: Fri, 02 Dec 2011 21:27:37 -0000 To: commits@hive.apache.org From: heyongqiang@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20111202212737.89C2023888E7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: heyongqiang Date: Fri Dec 2 21:27:37 2011 New Revision: 1209696 URL: http://svn.apache.org/viewvc?rev=1209696&view=rev Log: Hive-2607: Add caching to json_tuple (Kevin Wilfong via He Yongqiang) Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java?rev=1209696&r1=1209695&r2=1209696&view=diff ============================================================================== --- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java (original) +++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFJSONTuple.java Fri Dec 2 21:27:37 2011 @@ -19,6 +19,8 @@ package org.apache.hadoop.hive.ql.udf.generic; import java.util.ArrayList; +import java.util.LinkedHashMap; +import java.util.Map; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -55,6 +57,28 @@ public class GenericUDTFJSONTuple extend boolean pathParsed = false; boolean seenErrors = false; + //An LRU cache using a linked hash map + static class HashCache extends LinkedHashMap { + + private static final int CACHE_SIZE = 16; + private static final int INIT_SIZE = 32; + private static final float LOAD_FACTOR = 0.6f; + + HashCache() { + super(INIT_SIZE, LOAD_FACTOR); + } + + private static final long serialVersionUID = 1; + + @Override + protected boolean removeEldestEntry(Map.Entry eldest) { + return size() > CACHE_SIZE; + } + + } + + static Map jsonObjectCache = new HashCache(); + @Override public void close() throws HiveException { } @@ -124,7 +148,11 @@ public class GenericUDTFJSONTuple extend return; } try { - JSONObject jsonObj = new JSONObject(jsonStr); + JSONObject jsonObj = jsonObjectCache.get(jsonStr); + if (jsonObj == null) { + jsonObj = new JSONObject(jsonStr); + jsonObjectCache.put(jsonStr, jsonObj); + } for (int i = 0; i < numCols; ++i) { if (jsonObj.isNull(paths[i])) {