From dev-return-684-archive-asf-public=cust-asf.ponee.io@heron.incubator.apache.org Sun Apr 8 01:50:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B6D1718064E for ; Sun, 8 Apr 2018 01:50:13 +0200 (CEST) Received: (qmail 24546 invoked by uid 500); 7 Apr 2018 23:50:12 -0000 Mailing-List: contact dev-help@heron.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@heron.incubator.apache.org Delivered-To: mailing list dev@heron.incubator.apache.org Received: (qmail 24533 invoked by uid 99); 7 Apr 2018 23:50:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Apr 2018 23:50:12 +0000 From: GitBox To: dev@heron.apache.org Subject: [GitHub] sreev commented on a change in pull request #2853: package rename and related fixes Message-ID: <152314501221.27689.4808942722542043455.gitbox@gitbox.apache.org> Date: Sat, 07 Apr 2018 23:50:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sreev commented on a change in pull request #2853: package rename and related fixes URL: https://github.com/apache/incubator-heron/pull/2853#discussion_r179930942 ########## File path: eco-heron-examples/src/java/org/apache/heron/examples/eco/EvenAndOddBolt.java ########## @@ -0,0 +1,76 @@ +// Copyright 2018 Twitter. All rights reserved. Review comment: i want to keep the any other changes (including copyright that you suggested) separate from package renaming. also, i am waiting to hear back from Mentors, if a long single would be convenient or the current way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services