heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ajorgensen commented on a change in pull request #2864: S3Uploader improvements
Date Wed, 11 Apr 2018 19:26:17 GMT
ajorgensen commented on a change in pull request #2864: S3Uploader improvements
URL: https://github.com/apache/incubator-heron/pull/2864#discussion_r180870780
 
 

 ##########
 File path: heron/uploaders/src/java/org/apache/heron/uploader/s3/S3Uploader.java
 ##########
 @@ -143,11 +143,14 @@ public void initialize(Config config) {
       builder.setClientConfiguration(clientCfg);
     }
 
-    s3Client = builder.withRegion(customRegion)
-            .withPathStyleAccessEnabled(true)
-            .withChunkedEncodingDisabled(true)
-            .withPayloadSigningEnabled(true)
-            .build();
+    if (customRegion != null && !customRegion.equals("")) {
 
 Review comment:
   Great suggestion, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message