heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashvina commented on a change in pull request #2839: fix healthmgr metrics
Date Mon, 09 Apr 2018 18:05:46 GMT
ashvina commented on a change in pull request #2839: fix healthmgr metrics
URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180164965
 
 

 ##########
 File path: heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManager.java
 ##########
 @@ -211,11 +219,13 @@ public static void main(String[] args) throws Exception {
     LOG.info("Initializing health manager");
     healthManager.initialize();
 
-    LOG.info("Starting Health Manager metirc posting thread");
     HealthManagerMetrics publishingMetricsRunnable = null;
     if (hasOption(cmd, CliArgs.METRICSMGR_PORT)) {
-      publishingMetricsRunnable = new HealthManagerMetrics(
-          Integer.valueOf(getOptionValue(cmd, CliArgs.METRICSMGR_PORT)));
+      LOG.info("Starting Health Manager metirc posting thread");
 
 Review comment:
   Minor typo, *metirc*

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message