heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashvina commented on a change in pull request #2839: fix healthmgr metrics
Date Mon, 09 Apr 2018 16:24:22 GMT
ashvina commented on a change in pull request #2839: fix healthmgr metrics
URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180152364
 
 

 ##########
 File path: heron/executor/src/python/heron_executor.py
 ##########
 @@ -498,7 +498,11 @@ def _get_healthmgr_cmd(self):
                      "--cluster", self.cluster,
                      "--role", self.role,
                      "--environment", self.environment,
-                     "--topology_name", self.topology_name, "--verbose"]
+                     "--topology_name", self.topology_name,
+                     "--metricsmgr_port", self.metrics_manager_port,
+                     "--system_config_file", self.heron_internals_config_file,
+                     "--override_config_file", self.override_config_file,
+                     "--verbose"]
 
 Review comment:
   In another PR (#2821), the verbose flag was removed since it was generating a lot of noisy
logs. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message