heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] erenavsarogullari commented on issue #2853: package rename and related fixes
Date Sun, 08 Apr 2018 10:03:17 GMT
erenavsarogullari commented on issue #2853: package rename and related fixes
URL: https://github.com/apache/incubator-heron/pull/2853#issuecomment-379537653
 
 
   @sreev , Following changes needs to be `org.apache.*` as well on your branch. Also i tested
these changes locally by running integration-tests.
   
   **1- File:** /heron/integration_test/src/scala/BUILD
   ```
   [Row 12] srcs = glob(["com/twitter/heron/integration_test/**/*.scala"]),
   [Row 20] main_class = "com.twitter.heron.integration_test.topology.scala_streamlet_with_filter_and_transform.ScalaStreamletWithFilterAndTransform"
   ```
   
   **2- File:** /scripts/packages/BUILD
   ```
   [Row 352] strip_prefix = '/integration_test/src/scala/com/twitter/heron/integration_test/topology/'
   ```
   
   **3- File:** scripts/run_integration_test.sh
   ```
   [Row 11] SCALA_TESTS_DIR="integration_test/src/scala/com/twitter/heron/integration_test/topology"
   ```
   
   **4- File:** integration_test/src/scala/org/apache/heron/integration_test/common/ScalaIntegrationTestBase.scala
   ```
   //Please add the following lines
   import org.apache.heron.streamlet.scala.Builder
   import org.apache.heron.streamlet.scala.impl.BuilderImpl
   ```
   **5- File:** 
   integration_test/src/scala/org/apache/heron/integration_test/topology/scala_streamlet_with_filter_and_transform/ScalaStreamletWithFilterAndTransform.scala
   ```
   //Please remove the following line
   import org.apache.heron.integration_test.common.AbstractTestTopology
   ```
   ```
   //Please add the following lines
   import org.apache.heron.integration_test.common.{
     AbstractTestTopology,
     ScalaIntegrationTestBase
   }
   import org.apache.heron.streamlet.scala.{Builder, SerializableTransformer}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message