heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …
Date Fri, 06 Apr 2018 00:10:11 GMT
Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that
when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179632002
 
 

 ##########
 File path: heron/stmgr/src/cpp/manager/stmgr-clientmgr.cpp
 ##########
 @@ -131,7 +131,7 @@ StMgrClient* StMgrClientMgr::CreateClient(const sp_string& _other_stmgr_id,
 bool StMgrClientMgr::SendTupleStreamMessage(sp_int32 _task_id, const sp_string& _stmgr_id,
                                             const proto::system::HeronTupleSet2& _msg)
{
   auto iter = clients_.find(_stmgr_id);
-  CHECK(iter != clients_.end());
+  CHECK(iter != clients_.end()) << "Stmgr " << _stmgr_id << " is not found
in client list";
 
 Review comment:
   Would prefer `Failed to find the client to Stmgr xxx`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message