heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …
Date Fri, 06 Apr 2018 00:10:11 GMT
Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that
when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179628026
 
 

 ##########
 File path: heron/instance/src/cpp/boltimpl/bolt-instance.cpp
 ##########
 @@ -86,13 +86,13 @@ void BoltInstance::Start() {
 
 void BoltInstance::Activate() {
   LOG(INFO) << "Not doing anything in Bolt Activate";
-  CHECK(!active_);
+  CHECK(!active_) << "Bolt instance has been started already";
   active_ = true;
 }
 
 void BoltInstance::Deactivate() {
   LOG(INFO) << "Not doing anything in Bolt Dacctivate";
-  CHECK(active_);
+  CHECK(!active_) << "Bolt instance is not active";
 
 Review comment:
   logic changed: 
   
   `CHECK(active_) << "Bolt instance is not active"`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message