heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …
Date Fri, 06 Apr 2018 00:10:11 GMT
Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that
when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179628759
 
 

 ##########
 File path: heron/statemgrs/src/cpp/statemgr/heron-zkstatemgr.cpp
 ##########
 @@ -74,31 +74,31 @@ HeronZKStateMgr::~HeronZKStateMgr() {
 
 void HeronZKStateMgr::InitTree() {
   // Needs to be implemented
-  CHECK(false);
+  CHECK(false) << "HeronZKStateMgr::InitTree() is not implemented yet";
 }
 
 void HeronZKStateMgr::SetTMasterLocationWatch(const std::string& topology_name,
                                               VCallback<> watcher) {
-  CHECK(watcher);
-  CHECK(!topology_name.empty());
+  CHECK(watcher) << "Watcher callback is missing in SetTMasterLocationWatch";
+  CHECK(!topology_name.empty()) << "Topology name is missing";
 
   tmaster_location_watcher_info_ = new TMasterLocationWatchInfo(std::move(watcher), topology_name);
   SetTMasterLocationWatchInternal();
 }
 
 void HeronZKStateMgr::SetMetricsCacheLocationWatch(const std::string& topology_name,
-                                              VCallback<> watcher) {
-  CHECK(watcher);
-  CHECK(!topology_name.empty());
+                                                   VCallback<> watcher) {
 
 Review comment:
   unrelated indent change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message