heron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ajorgensen opened a new pull request #2831: Fix bug in dry-run argument for update command
Date Sat, 31 Mar 2018 19:01:33 GMT
ajorgensen opened a new pull request #2831: Fix bug in dry-run argument for update command
URL: https://github.com/apache/incubator-heron/pull/2831
 
 
   Since list_extra_args is an array the `+=` operator deconstructs a
   string and add each character as an individual array element. This made
   it so when the update command it would not detect if it was in dry-run
   mode and always run the update command. By encapsulating the `--dry-run`
   string in an list it is properly added as an argument and runs with the
   expected behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message