Mailing-List: contact dev-help@heron.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@heron.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CAP5ce1wz6bVFRFW_8ifp4k2Vpn83Q6VZjYV25ppF59-YTd1TiQ@mail.gmail.com>
References: <CABvwrKS1e6O6jj5V-a5Z541n8WyoS0VLhd2RkRoBKCf=KnNdYA@mail.gmail.com>
 <CAP5ce1wz6bVFRFW_8ifp4k2Vpn83Q6VZjYV25ppF59-YTd1TiQ@mail.gmail.com>
From: Thomas Cooper <tom.n.cooper@gmail.com>
Date: Wed, 27 Sep 2017 11:22:48 +0100
Message-ID: <CABvwrKRsOHDwmVv8CKfy0xvptUmdCvyYaeP7H0pe2omtEyNamg@mail.gmail.com>
Subject: Re: InfluxDB Metric Sink
To: dev@heron.incubator.apache.org
Content-Type: multipart/alternative; boundary="001a1140f5faceb256055a292ed7"
archived-at: Wed, 27 Sep 2017 10:23:33 -0000

--001a1140f5faceb256055a292ed7
Content-Type: text/plain; charset="UTF-8"

Thanks Maosong,

So if was going to submit this as a PR (once it I have thoroughly tested
it) I only need to document its config options in the
example/metrics_sinks.yaml and not anywhere else (other than in the sinks
java_doc)?

Tom Cooper
W: www.tomcooper.org.uk  | Twitter: @tomncooper
<https://twitter.com/tomncooper>

On 27 September 2017 at 11:17, Fu Maosong <maosongfu@gmail.com> wrote:

> If it is only an example, you can just put it in the
> example/metrics_sinks.yaml.
> If you need to use it in actual env, then put it in the actual schedule
> config folder.
>
> 2017-09-27 2:41 GMT-07:00 Thomas Cooper <tom.n.cooper@gmail.com>:
>
> > Hi,
> >
> > I'm working on adding in support for sending metrics to InfluxDB.
> >
> > I was just wondering where the example config template for the sink
> should
> > live?
> >
> > There are multiple config folders under heron/config/src/yaml/conf (for
> > each of the schedulers), should I just put my sink's config in the
> > example/metrics_sinks.yaml or do I need to add a (commented out) example
> in
> > each scheduler's folder?
> >
> > Tom Cooper
> > W: www.tomcooper.org.uk  | Twitter: @tomncooper
> > <https://twitter.com/tomncooper>
> >
>
>
>
> --
> With my best Regards
> ------------------
> Fu Maosong
> Twitter Inc.
> Mobile: +001-415-244-7520
>

--001a1140f5faceb256055a292ed7--