Mailing-List: contact user-help@helix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@helix.apache.org
Received-SPF: pass (athena.apache.org: domain of
 prvs=4197aaa61=zzhang@linkedin.com designates 69.28.149.80 as permitted
 sender)
From: Zhen Zhang <zzhang@linkedin.com>
To: "user@helix.apache.org" <user@helix.apache.org>
Subject: RE: Upgrade to 0.7.1
Thread-Topic: Upgrade to 0.7.1
Thread-Index: AQHQF1gAG5sPSV6MREWffm+V7cHXpZyRmKEAgAAIiYD//6+ZQA==
Date: Mon, 15 Dec 2014 23:36:47 +0000
Message-ID: <23CA11DC8830BA44A37C6B44B14D013C9559A20C@ESV4-MB02.linkedin.biz>
References: <548D13EC.3030904@gmail.com>
 <CALyTCcH1=oNGzhAjsVj7KrQn3U3qBGMQSy9YG3nKn3vhLmsG0A@mail.gmail.com>,<548F430F.4050905@gmail.com>
In-Reply-To: <548F430F.4050905@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Vinayak, =0A=
=0A=
I created a simple test case using you code snippet, but couldn't repo the =
problem:=0A=
https://issues.apache.org/jira/browse/HELIX-561=0A=
=0A=
Let's use this jira for further discussion.=0A=
=0A=
Thanks,=0A=
Zhen=0A=
=0A=
________________________________________=0A=
From: Vinayak Borkar [vinayakb@gmail.com]=0A=
Sent: Monday, December 15, 2014 12:22 PM=0A=
To: user@helix.apache.org=0A=
Subject: Re: Upgrade to 0.7.1=0A=
=0A=
Hi Zhen,=0A=
=0A=
Thanks for your response.=0A=
=0A=
Here is a snippet of code that creates HelixManager and registers the=0A=
state model factory. As I indicated in my previous email, this code used=0A=
to work with 0.6.2-incubating. All I did was to do whatever I had to do=0A=
to fix the compilation issues.=0A=
=0A=
=0A=
hManager =3D HelixManagerFactory.getZKHelixManager(clusterName, id,=0A=
InstanceType.PARTICIPANT, zkAddr);=0A=
hManager.getStateMachineEngine().registerStateModelFactory(StateMachineType=
.MASTER_SLAVE.getStateModelDefId(),=0A=
                     new MasterSlaveStateModelFactory(this));=0A=
hManager.connect();=0A=
hManager.addExternalViewChangeListener(router);=0A=
hManager.addInstanceConfigChangeListener(router);=0A=
hManager.addLiveInstanceChangeListener(router);=0A=
=0A=
=0A=
The state model class looks like this:=0A=
=0A=
=0A=
public class MasterSlaveStateModel extends TransitionHandler {=0A=
     @Transition(to =3D "SLAVE", from =3D "OFFLINE")=0A=
     public void onBecomeSlaveFromOffline(Message message,=0A=
NotificationContext context) throws Exception {=0A=
        ...=0A=
     }=0A=
=0A=
     @Transition(to =3D "MASTER", from =3D "SLAVE")=0A=
     public void onBecomeMasterFromSlave(Message message,=0A=
NotificationContext context) throws Exception {=0A=
        ...=0A=
     }=0A=
=0A=
     @Transition(to =3D "SLAVE", from =3D "MASTER")=0A=
     public void onBecomeSlaveFromMaster(Message message,=0A=
NotificationContext context) throws Exception {=0A=
        ...=0A=
     }=0A=
=0A=
     @Transition(to =3D "OFFLINE", from =3D "SLAVE")=0A=
     public void onBecomeOfflineFromSlave(Message message,=0A=
NotificationContext context) throws Exception {=0A=
        ...=0A=
     }=0A=
=0A=
     @Transition(to =3D "DROPPED", from =3D "OFFLINE")=0A=
     public void onBecomeDroppedFromOffline(Message message,=0A=
NotificationContext context) throws Exception {=0A=
        ...=0A=
     }=0A=
=0A=
     @Transition(to =3D "OFFLINE", from =3D "ERROR")=0A=
     public void onBecomeOfflineFromError(Message message,=0A=
NotificationContext context) throws Exception {=0A=
        ...=0A=
     }=0A=
=0A=
     ...=0A=
}=0A=
=0A=
=0A=
Thanks,=0A=
Vinayak=0A=
=0A=
=0A=
On 12/15/14, 11:52 AM, Zhen Zhang wrote:=0A=
> Hi Vinayak,=0A=
>=0A=
> We need to add documentation for upgrading 0.6.x to 0.7.1:=0A=
> https://issues.apache.org/jira/browse/HELIX-560=0A=
>=0A=
> 0.7.1 provides a new set of API. it's not backward compatible in the=0A=
> sense that all errors should be exposed in compile time. Regarding the=0A=
> state machine receiving two OFFLINE->SLAVE transitions, could you please=
=0A=
> share how you create helix-manager and register state model. Also what's=
=0A=
> your state model look like?=0A=
>=0A=
> Thanks,=0A=
> Jason=0A=
>=0A=
>=0A=
> On Sat, Dec 13, 2014 at 8:37 PM, Vinayak Borkar <vinayakb@gmail.com=0A=
> <mailto:vinayakb@gmail.com>> wrote:=0A=
>=0A=
>     Hi Guys,=0A=
>=0A=
>=0A=
>     Is there a document/checklist to help upgrade and application from=0A=
>     0.6.x to 0.7.1?=0A=
>=0A=
>     Here are a few things I had to do to get my code to compile:=0A=
>=0A=
>     1. Change StateModelFactory -> StateTransitionHandlerFactory=0A=
>     2. Change StateModel -> TransitionHandler=0A=
>     3. Use PartitionId and StateModelDefId instead of String.=0A=
>=0A=
>     Although the code compiles, it does not work as it used to in 0.6.x.=
=0A=
>=0A=
>     For example, I am seeing my state machine (Master Slave) receive an=
=0A=
>     OFFLINE->SLAVE transition twice.=0A=
>=0A=
>     Thanks,=0A=
>     Vinayak=0A=
>=0A=
=0A=