helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [2/7] helix git commit: Fix TestBatchMessage test fail
Date Wed, 04 Oct 2017 01:49:43 GMT
Fix TestBatchMessage test fail

Test fail because new NO_OP message send as new MessageHandlerFactory registered.


Project: http://git-wip-us.apache.org/repos/asf/helix/repo
Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/d5a2395d
Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/d5a2395d
Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/d5a2395d

Branch: refs/heads/master
Commit: d5a2395d207da618e767d1f07e20fa116d716cb3
Parents: f9f554e
Author: Junkai Xue <jxue@linkedin.com>
Authored: Wed Feb 8 17:12:18 2017 -0800
Committer: Junkai Xue <jxue@linkedin.com>
Committed: Tue Oct 3 15:07:07 2017 -0700

----------------------------------------------------------------------
 .../java/org/apache/helix/integration/TestBatchMessage.java  | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/helix/blob/d5a2395d/helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
----------------------------------------------------------------------
diff --git a/helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java b/helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
index e4a2990..9e62c0d 100644
--- a/helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
+++ b/helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
@@ -105,7 +105,9 @@ public class TestBatchMessage extends ZkIntegrationTestBase {
         ClusterStateVerifier.verifyByZkCallback(new BestPossAndExtViewZkVerifier(ZK_ADDR,
             clusterName));
     Assert.assertTrue(result);
-    Assert.assertTrue(listener._maxNbOfChilds <= 2,
+    // Change to three is because there is an extra factory registered
+    // So one extra NO_OP message send
+    Assert.assertTrue(listener._maxNbOfChilds <= 3,
         "Should get no more than 2 messages (O->S and S->M)");
 
     // clean up
@@ -185,7 +187,9 @@ public class TestBatchMessage extends ZkIntegrationTestBase {
         ClusterStateVerifier.verifyByZkCallback(new BestPossAndExtViewZkVerifier(ZK_ADDR,
             clusterName));
     Assert.assertTrue(result);
-    Assert.assertTrue(listener._maxNbOfChilds <= 2,
+    // Change to three is because there is an extra factory registered
+    // So one extra NO_OP message send
+    Assert.assertTrue(listener._maxNbOfChilds <= 3,
         "Should get no more than 2 messages (O->S and S->M)");
 
     // clean up


Mime
View raw message