Return-Path: X-Original-To: apmail-helix-commits-archive@minotaur.apache.org Delivered-To: apmail-helix-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5B29176DD for ; Sat, 14 Mar 2015 06:03:59 +0000 (UTC) Received: (qmail 98236 invoked by uid 500); 14 Mar 2015 06:03:59 -0000 Delivered-To: apmail-helix-commits-archive@helix.apache.org Received: (qmail 98197 invoked by uid 500); 14 Mar 2015 06:03:59 -0000 Mailing-List: contact commits-help@helix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@helix.apache.org Delivered-To: mailing list commits@helix.apache.org Received: (qmail 98183 invoked by uid 99); 14 Mar 2015 06:03:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Mar 2015 06:03:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 14 Mar 2015 06:03:58 +0000 Received: (qmail 97270 invoked by uid 99); 14 Mar 2015 06:03:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Mar 2015 06:03:38 +0000 Date: Sat, 14 Mar 2015 06:03:38 +0000 (UTC) From: "Zhen Zhang (JIRA)" To: commits@helix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HELIX-576) Make StateModelFactory change backward compatible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HELIX-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhen Zhang updated HELIX-576: ----------------------------- Description: In order to fix HELIX-552, we made a backward incompatible change in StateModelFactory: {noformat} - public abstract T createNewStateModel(String partitionName) + public abstract T createNewStateModel(String resourceName, String partitionName) {noformat} This introduces some issues when people upgrade helix. To mitigate the problem, we need bring back the old abstract method. Make it deprecated instead of removing it. The backward incompatible commit is here: https://git-wip-us.apache.org/repos/asf?p=helix.git;a=commit;h=9ddd0af347037f585a52b83bbc3a6b11a3934c82 was: In order to fix HELIX-552, we made a backward incompatible change in StateModelFactory: {noformat} - public abstract T createNewStateModel(String partitionName) + public abstract T createNewStateModel(String resourceName, String partitionName) {noformat} This introduces some issues when people upgrade helix. To mitigate the problem, we need bring back the old abstract method. Make it deprecated instead of removing it. > Make StateModelFactory change backward compatible > ------------------------------------------------- > > Key: HELIX-576 > URL: https://issues.apache.org/jira/browse/HELIX-576 > Project: Apache Helix > Issue Type: Bug > Reporter: Zhen Zhang > > In order to fix HELIX-552, we made a backward incompatible change in StateModelFactory: > {noformat} > - public abstract T createNewStateModel(String partitionName) > + public abstract T createNewStateModel(String resourceName, String partitionName) > {noformat} > This introduces some issues when people upgrade helix. To mitigate the problem, we need bring back the old abstract method. Make it deprecated instead of removing it. > The backward incompatible commit is here: > https://git-wip-us.apache.org/repos/asf?p=helix.git;a=commit;h=9ddd0af347037f585a52b83bbc3a6b11a3934c82 -- This message was sent by Atlassian JIRA (v6.3.4#6332)