Return-Path: X-Original-To: apmail-helix-commits-archive@minotaur.apache.org Delivered-To: apmail-helix-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D23010ADF for ; Wed, 19 Nov 2014 04:23:56 +0000 (UTC) Received: (qmail 67441 invoked by uid 500); 19 Nov 2014 04:23:56 -0000 Delivered-To: apmail-helix-commits-archive@helix.apache.org Received: (qmail 67342 invoked by uid 500); 19 Nov 2014 04:23:55 -0000 Mailing-List: contact commits-help@helix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@helix.apache.org Delivered-To: mailing list commits@helix.apache.org Received: (qmail 67313 invoked by uid 99); 19 Nov 2014 04:23:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 04:23:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 19 Nov 2014 04:23:54 +0000 Received: (qmail 67264 invoked by uid 99); 19 Nov 2014 04:23:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 04:23:34 +0000 Date: Wed, 19 Nov 2014 04:23:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@helix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HELIX-550) ZKHelixManager does not shutdown GenericHelixController threads. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HELIX-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217391#comment-14217391 ] ASF GitHub Bot commented on HELIX-550: -------------------------------------- Github user kanakb commented on a diff in the pull request: https://github.com/apache/helix/pull/11#discussion_r20557176 --- Diff: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java --- @@ -573,6 +573,15 @@ public void shutdownClusterStatusMonitor(String clusterName) { } } + public void shutdown() throws InterruptedException { + stopRebalancingTimer(); + while (_eventThread.isAlive()) + { + _eventThread.interrupt(); + _eventThread.join(1000); --- End diff -- Can you change this to a constant variable? > ZKHelixManager does not shutdown GenericHelixController threads. > ---------------------------------------------------------------- > > Key: HELIX-550 > URL: https://issues.apache.org/jira/browse/HELIX-550 > Project: Apache Helix > Issue Type: Bug > Reporter: Antony T Curtis > Priority: Critical > > ZKHelixManager does not shutdown GenericHelixController threads. -- This message was sent by Atlassian JIRA (v6.3.4#6332)