helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-550) ZKHelixManager does not shutdown GenericHelixController threads.
Date Wed, 19 Nov 2014 04:33:33 GMT

    [ https://issues.apache.org/jira/browse/HELIX-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217400#comment-14217400
] 

ASF GitHub Bot commented on HELIX-550:
--------------------------------------

Github user atcurtis commented on a diff in the pull request:

    https://github.com/apache/helix/pull/11#discussion_r20557401
  
    --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java ---
    @@ -543,6 +554,19 @@ public void disconnect() {
           _zkclient.close();
           _zkclient = null;
           LOG.info("Cluster manager: " + _instanceName + " disconnected");
    +
    +      if (_controller != null) {
    +        try {
    +          _controller.shutdown();
    +        }
    --- End diff --
    
    np.


> ZKHelixManager does not shutdown GenericHelixController threads.
> ----------------------------------------------------------------
>
>                 Key: HELIX-550
>                 URL: https://issues.apache.org/jira/browse/HELIX-550
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Antony T Curtis
>            Priority: Critical
>
> ZKHelixManager does not shutdown GenericHelixController threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message