helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-525) Drop a partition from resource ideal-state shall bring partition to initial state and then DROPPED state
Date Tue, 21 Oct 2014 05:59:34 GMT

    [ https://issues.apache.org/jira/browse/HELIX-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178000#comment-14178000
] 

ASF GitHub Bot commented on HELIX-525:
--------------------------------------

Github user kanakb commented on a diff in the pull request:

    https://github.com/apache/helix/pull/7#discussion_r19130517
  
    --- Diff: helix-core/src/test/java/org/apache/helix/integration/TestDrop.java ---
    @@ -481,11 +507,27 @@ public void testDropSinglePartitionSemiAuto() throws Exception {
             4, // partitions per resource
             n, // number of nodes
             2, // replicas
    -        "MasterSlave", true); // do rebalance
    +        "MasterSlave", mode, (IdealState.RebalanceMode.FULL_AUTO.equals(mode) || IdealState.RebalanceMode.SEMI_AUTO
    +        .equals(mode))); // do rebalance only when it is in AUTO or SEMI-AUTO mode
    --- End diff --
    
    Why is the default rebalance behavior insufficient for CUSTOMIZED mode?


> Drop a partition from resource ideal-state shall bring partition to initial state and
then DROPPED state
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HELIX-525
>                 URL: https://issues.apache.org/jira/browse/HELIX-525
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Zhen Zhang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> If we manually remove a partition from ideal-state, Helix should bring the partition
to initial state (e.g. OFFLINE) on all hosts and then to DROPPED state.
> - Add an integration test to verify this (for AUTO, SEMI_AUTO, and CUSTOM modes)
> - Fix it if not behave in the  expected way



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message