helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-390) Race condition: Checking HelixManager#isConnected is unreliable
Date Mon, 24 Feb 2014 19:21:21 GMT

    [ https://issues.apache.org/jira/browse/HELIX-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910691#comment-13910691

Hudson commented on HELIX-390:

UNSTABLE: Integrated in helix #1233 (See [https://builds.apache.org/job/helix/1233/])
[HELIX-390] Force message handler registration even when ZK connection state is flaky (kanak:
rev a302564a345f4c5ff92559fe9cad126acad740c9)
* helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java

> Race condition: Checking HelixManager#isConnected is unreliable
> ---------------------------------------------------------------
>                 Key: HELIX-390
>                 URL: https://issues.apache.org/jira/browse/HELIX-390
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Kanak Biscuitwala
>            Assignee: Kanak Biscuitwala
> This led to a NPE in trying to execute state transitions due to the fact that the state
model was never re-registered after a post-GC reconnection.
> The fix is to invoke the message handler's onConnected method in handleNewSession, and
to put all necessary on-connect logic inside this method.

This message was sent by Atlassian JIRA

View raw message