helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kanak Biscuitwala (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HELIX-166) Rename modes to auto, semi-auto, and custom
Date Wed, 14 Aug 2013 20:27:47 GMT

     [ https://issues.apache.org/jira/browse/HELIX-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kanak Biscuitwala updated HELIX-166:
------------------------------------

    Attachment: 0001-HELIX-166-Rename-modes-to-auto-semi-auto-and-custom.patch

Attached the patch.

I called the new modes FULL_AUTO, SEMI_AUTO, CUSTOMIZED, and USER_DEFINED, and put them under
an enum called RebalanceMode. For now, setting this mode or the previous mode will set the
other mode for backward and forward compatibility. Similarly, if for some reason one mode
is not set (most common case is the presence of the old mode due to an older controller),
there is an internal check for the other mode and the corresponding conversion is made.

Code review: https://reviews.apache.org/r/13444/
                
> Rename modes to auto, semi-auto, and custom
> -------------------------------------------
>
>                 Key: HELIX-166
>                 URL: https://issues.apache.org/jira/browse/HELIX-166
>             Project: Apache Helix
>          Issue Type: Task
>          Components: helix-core
>            Reporter: Kanak Biscuitwala
>            Assignee: Kanak Biscuitwala
>            Priority: Minor
>         Attachments: 0001-HELIX-166-Rename-modes-to-auto-semi-auto-and-custom.patch
>
>
> Auto vs AutoRebalance is potentially confusing as a naming scheme. A possible alternative
is to rename these to Semi-Auto and Auto.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message