helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dafu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HELIX-135) Not handling InterruptedException correctly in helix
Date Sat, 22 Jun 2013 23:15:20 GMT
dafu created HELIX-135:
--------------------------

             Summary: Not handling InterruptedException correctly in helix
                 Key: HELIX-135
                 URL: https://issues.apache.org/jira/browse/HELIX-135
             Project: Apache Helix
          Issue Type: Bug
            Reporter: dafu
            Assignee: dafu


we are not handling InterruptedException in the correct way. For example, in HelixStateTransitionHandler,
we are catching all Exceptions (including InterruptedException) but never honor the interrupt
signal by throwing InterruptedException again or call thread.interrupt(). This prevents any
helix task to be cancelled, which in turn prevents executor thread pool to be shut down. This
is problematic, for example, in case of zk session expiry, we are canceling leftover tasks
but actually they never being cancelled and continue to write to zk in the new session. 

We need also be careful about other places where we catch InterruptedException but not honoring
it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message