Return-Path: X-Original-To: apmail-helix-commits-archive@minotaur.apache.org Delivered-To: apmail-helix-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2EBDDF3CA for ; Thu, 4 Apr 2013 22:30:39 +0000 (UTC) Received: (qmail 99570 invoked by uid 500); 4 Apr 2013 22:30:38 -0000 Delivered-To: apmail-helix-commits-archive@helix.apache.org Received: (qmail 99482 invoked by uid 500); 4 Apr 2013 22:30:38 -0000 Mailing-List: contact commits-help@helix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@helix.apache.org Delivered-To: mailing list commits@helix.apache.org Received: (qmail 99416 invoked by uid 99); 4 Apr 2013 22:30:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Apr 2013 22:30:38 +0000 X-ASF-Spam-Status: No, hits=-2002.3 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 04 Apr 2013 22:30:37 +0000 Received: (qmail 97527 invoked by uid 99); 4 Apr 2013 22:30:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Apr 2013 22:30:16 +0000 Date: Thu, 4 Apr 2013 22:30:16 +0000 (UTC) From: "kishore gopalakrishna (JIRA)" To: commits@helix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HELIX-77) Skip tests in default build or separate unit/integration tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HELIX-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622899#comment-13622899 ] kishore gopalakrishna commented on HELIX-77: -------------------------------------------- Hi Max, I am not able to apply the patch, looks like some changes were made the pom.xml. Can you please merge the changes and re-submit the patch ? > Skip tests in default build or separate unit/integration tests > -------------------------------------------------------------- > > Key: HELIX-77 > URL: https://issues.apache.org/jira/browse/HELIX-77 > Project: Apache Helix > Issue Type: Improvement > Reporter: Max Calderoni > Priority: Minor > Attachments: cleanups.patch, helix-77.patch, separateintegtests.patch > > > A couple of miscellaneous questions about how you require building helix. > Would it be possible to skip tests by default in your pom? > Normally, after cloning sources (for experimenting/browsing), you would do: > mvn clean install > which for helix should take maybe 10-30 seconds. > Because you have tests turned on by default the build takes much much longer (it looks like there are integration tests in the mix, not only fast unit tests). > I think it would be more usable for people doing 'mvn clean install' rather than the more verbose: > mvn clean install -Dmaven.test.skip.exec=true > Attaching a patch that shows what i mean in the pom. > The other related question is about integration tests. The reason why takes so long to build is maybe because not all tests being run are unit tests. > Sometimes there is no clear distinction between integration and unit tests, but the point is that the build should be fast, so one way to distinguish, arguably, is that if a test is slow is not a unit test. > I can show one way of separating unit and integration tests in Maven (Maven does not have very good support for this, there are different ways to work around it) in a later post to this. Please let me know if there is any interest in correcting this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira