Return-Path: X-Original-To: apmail-helix-commits-archive@minotaur.apache.org Delivered-To: apmail-helix-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F5A0104C0 for ; Wed, 10 Apr 2013 06:08:41 +0000 (UTC) Received: (qmail 79504 invoked by uid 500); 10 Apr 2013 06:08:40 -0000 Delivered-To: apmail-helix-commits-archive@helix.apache.org Received: (qmail 79448 invoked by uid 500); 10 Apr 2013 06:08:40 -0000 Mailing-List: contact commits-help@helix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@helix.apache.org Delivered-To: mailing list commits@helix.apache.org Received: (qmail 79323 invoked by uid 99); 10 Apr 2013 06:08:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2013 06:08:40 +0000 X-ASF-Spam-Status: No, hits=-2002.4 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Apr 2013 06:08:38 +0000 Received: (qmail 76976 invoked by uid 99); 10 Apr 2013 06:08:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2013 06:08:16 +0000 Date: Wed, 10 Apr 2013 06:08:16 +0000 (UTC) From: "Vinayak Borkar (JIRA)" To: commits@helix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HELIX-73) Remove assumption that Instance.id is always host_port MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HELIX-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627518#comment-13627518 ] Vinayak Borkar edited comment on HELIX-73 at 4/10/13 6:08 AM: -------------------------------------------------------------- I have attached a patch to fix this issue. Running tests after applying the patch yields the same number of failures as without it. I have filed HELIX-82 to capture the fact that there are test failures in code in trunk. Looking forward to reviews of this patch. was (Author: vinayakb): I have attached a patch to fix this issue. Running tests after applying the patch yields the same number of failures as without it. I have filed HELIX-82 to capture the fact that there are test failures in code in trunk. > Remove assumption that Instance.id is always host_port > ------------------------------------------------------ > > Key: HELIX-73 > URL: https://issues.apache.org/jira/browse/HELIX-73 > Project: Apache Helix > Issue Type: Improvement > Components: helix-core > Affects Versions: 0.6.0-incubating > Reporter: Vinayak Borkar > Fix For: 0.6.1-incubating > > Attachments: HELIX-73.patch > > > Currently, some parts of Helix make an assumption that the id of an Instance is always made up of a combination of host and port. Can this assumption be eliminated? If so, I can work on providing a patch that fixes this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira