Mailing-List: contact commits-help@helix.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@helix.incubator.apache.org
Date: Tue, 5 Feb 2013 00:40:12 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: commits@helix.incubator.apache.org
Message-ID: <JIRA.12630606.1359944121809.242627.1360024812861@arcas>
In-Reply-To: <JIRA.12630606.1359944121809@arcas>
References: <JIRA.12630606.1359944121809@arcas>
Subject: [jira] [Commented] (HELIX-41) fix intermittent test failures
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HELIX-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570796#comment-13570796 ] 

Hudson commented on HELIX-41:
-----------------------------

Integrated in helix #527 (See [https://builds.apache.org/job/helix/527/])
    HELIX-41: fix intermittent test failures (Revision f82ddf27009eb4e92e9fed65d90e64a267524ed0)

     Result = UNSTABLE
zzhang : 
Files : 
* helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertFireHistory.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java

                
> fix intermittent test failures
> ------------------------------
>
>                 Key: HELIX-41
>                 URL: https://issues.apache.org/jira/browse/HELIX-41
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: dafu
>            Assignee: dafu
>
> a few tests have the following pattern for assert test failure:
> sleep(xx) // wait zk callback to arrive or sth. similar
> assert(ret==true)
> but this depends on the zk callback latency and it's not stable.
> change it to:
> for (int i = 0; i < 10) {
>   if (ret == true)
>     break;
>   sleep(xx);
> }
> assert(ret == true)
> also in case of failure, we need to print out in assert(, "actual value that leads to failure") the actual value that leads to failure so we would know if the failure is caused by timeout or sth. else

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira