helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dafu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HELIX-41) fix intermittent test failures
Date Tue, 05 Feb 2013 19:52:11 GMT

     [ https://issues.apache.org/jira/browse/HELIX-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

dafu updated HELIX-41:
----------------------

    Description: 
a few tests have the following pattern for assert test failure:

sleep(xx) // wait zk callback to arrive or sth. similar
assert(ret==true)
but this depends on the zk callback latency and it's not stable.

change it to:
for (int i = 0; i < 10; i++) {
  if (ret == true)
    break;
  sleep(xx);
}
assert(ret == true)

also in case of failure, we need to print out in assert(, "actual value that leads to failure")
the actual value that leads to failure so we would know if the failure is caused by timeout
or sth. else

  was:
a few tests have the following pattern for assert test failure:

sleep(xx) // wait zk callback to arrive or sth. similar
assert(ret==true)
but this depends on the zk callback latency and it's not stable.

change it to:
for (int i = 0; i < 10) {
  if (ret == true)
    break;
  sleep(xx);
}
assert(ret == true)

also in case of failure, we need to print out in assert(, "actual value that leads to failure")
the actual value that leads to failure so we would know if the failure is caused by timeout
or sth. else

    
> fix intermittent test failures
> ------------------------------
>
>                 Key: HELIX-41
>                 URL: https://issues.apache.org/jira/browse/HELIX-41
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: dafu
>            Assignee: dafu
>
> a few tests have the following pattern for assert test failure:
> sleep(xx) // wait zk callback to arrive or sth. similar
> assert(ret==true)
> but this depends on the zk callback latency and it's not stable.
> change it to:
> for (int i = 0; i < 10; i++) {
>   if (ret == true)
>     break;
>   sleep(xx);
> }
> assert(ret == true)
> also in case of failure, we need to print out in assert(, "actual value that leads to
failure") the actual value that leads to failure so we would know if the failure is caused
by timeout or sth. else

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message