Mailing-List: contact httpclient-users-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpClient User Discussion" <httpclient-users@hc.apache.org>
Subject: Re: Possible to change default value for staleConnectionCheckEnabled?
From: Christopher Schultz <chris@christopherschultz.net>
To: httpclient-users@hc.apache.org
Reply-To: HttpClient User Discussion <httpclient-users@hc.apache.org>
References: <CACZkXPzPo=J2sY3ggSSpq=m0Rzd0rZmqyoEpMfDy49F6EzC3Xw@mail.gmail.com>
 <pony-65717fc66df51cd852fc6d953170d2c496086a91-62758664bc975d1128224a3850271c10b313dc46@httpclient-users.hc.apache.org>
 <pony-65717fc66df51cd852fc6d953170d2c496086a91-6850c77f80da9d571a9bc9ebd941d7ffe610c72b@httpclient-users.hc.apache.org>
 <2045dc0d-6ff1-3414-5bba-22ea2f8fd598@christopherschultz.net>
Message-ID: <eb9326ed-436f-8412-38e9-1a52c38bbbb4@christopherschultz.net>
Date: Wed, 12 Jul 2017 12:57:27 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <2045dc0d-6ff1-3414-5bba-22ea2f8fd598@christopherschultz.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
archived-at: Wed, 12 Jul 2017 16:57:34 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Gary,

On 7/12/17 12:17 PM, Christopher Schultz wrote:
> Gary,
> 
> On 7/12/17 12:05 PM, Christopher Schultz wrote:
>> Gary,
> 
>> Nope. That field is 100% undocumented 
>> (https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/or
g
>
>> 
/apache/http/client/config/RequestConfig.html#DEFAULT)
>> so messing-around with it seems like a bad idea.
> 
>> What do you suggest, specifically? It's a static final field, but
>> I don't believe we are running under a SecurityManager, so I
>> could probably use reflection to blast-away the value with one of
>> my choosing.
> 
>> I haven't looked at the code... is the DEFAULT object cloned (at 
>> least semantically) whenever a new RequestConfig object is built
>> to act as the default values for everything?
> 
> Looks like not. I don't see that RequestConfig.DEFAULT is useful
> in any way, unless client code decides to use it for some reason.

The client code in question looks like this:

===
       PoolingHttpClientConnectionManager httpClientConnectionManager
= new PoolingHttpClientConnectionManager(socketFactoryRegistry);

       httpClientConnectionManager.setDefaultMaxPerRoute(5);


httpClientConnectionManager.setDefaultSocketConfig(SocketConfig.custom()
.setSoTimeout(timeout).build());


       client =
HttpClients.custom().setConnectionManager(httpClientConnectionManager).b
uild();

       requestConfig =
RequestConfig.custom().setConnectTimeout(CONNECT_TIMEOUT).setConnectionR
equestTimeout(CONNECT_TIMEOUT).setSocketTimeout(timeout).build();
===

I'm not sure there is a way to do this other than with some really
ugly reflection from outside code.

Any suggestions?

Thanks,
- -chris


>> On 2017-07-11 18:43 (-0400), Gary Gregory
>> <garydgregory@gmail.com> wrote:
>>> Hi Chris,
>>> 
>>> Have you tried resetting 
>>> org.apache.http.client.config.RequestConfig.DEFAULT?
>>> 
>>> Gary
>>> 
>>> On Tue, Jul 11, 2017 at 12:54 PM, Christopher Schultz 
>>> <schultz@apache.org> wrote:
>>> 
>>>> All,
>>>> 
>>>> I have a conflict between two products that must operate in
>>>> the same JVM and same ClassLoader. One product was based
>>>> upon http-client 4.3 and another based upon 4.5. Nearly
>>>> everything works (thanks for the great backward
>>>> compatibility, folks!) except that the product relying upon
>>>> 4.3 semantics is expecting the default value for
>>>> staleConnectionCheckEnabled to be "true" while it is "false"
>>>> in the latest versions.
>>>> 
>>>> Unfortunately, patching the code of the "older" product is
>>>> very ... challenging.
>>>> 
>>>> Is there a system property or anything like that I can use
>>>> to change this default? Maybe a static 
>>>> setDefaultStateConnectionCheckEnabled(boolean) method? I 
>>>> realize that the whole staleConnectionCheckEnabled setting is
>>>>  deprecated, but having changed the default value for it is 
>>>> causing me some backward-compatibility headaches.
>>>> 
>>>> Thanks, -chris
>>>> 
>>>> -------------------------------------------------------------------
- -
>
>>>> 
- -
>>>> 
>>>> 
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
>>>> For additional commands, e-mail: 
>>>> httpclient-users-help@hc.apache.org
>>>> 
>>>> 
>>> 
> 
>> ---------------------------------------------------------------------
>
>> 
> 
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
>> For additional commands, e-mail: 
>> httpclient-users-help@hc.apache.org
> 
> 
> ---------------------------------------------------------------------
>
> 
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> For additional commands, e-mail:
> httpclient-users-help@hc.apache.org
> 
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJZZlT3AAoJEBzwKT+lPKRYehMP+gPqxIMnSrTEMTYg99Dk2yb6
myRvi97sW6648hlzRgRO7VvIHKGoK4ggPn3TRcwCuczyS3Ik/FMXmoGhdYgutnIT
41krI3zE2ZTTp+N4IMgQW6c5MHkALXw91Dd95cSAHAJEEsISSSNwSkhmylgtc4SI
ITRW8wAmqXRMUT+OZ28WIEzRsgnRcFhfnbSPAsQGbYaxJKk2ZWNenoNHCLJbtq47
JOzOJs4RsuZHk7n0CbOo5D3lUbo+FywYIvQRUD9zSN1k+Kjw4pyzodTjFoMDuIrI
I3U4VwF+jYFonua/Wh+GBaXWewVV1aBXoXSGmZJdlaXqwGwx6R0h5/b6Y/hGg+To
ahtMMcg2c+1A1S3+lZnrNVcbEGC2L6Izfnz2UBVQrG5tYUDT7nMwfIZnjNi2WPtA
pmKST+owTeI0ETwLGLV8h6TFcAz8F40H5TmV+7nlbRGT8TkwVNzTWXy0yQnYB+Ey
qkNIsjWA2OMiZv7eIr/5JN61c4RNqbDx9Br2oLZPrx4zLHLNiIxFCDi8M7Ba9gwB
NMHz1c0SSx+5PIouWnDuEsTMJ4aAHOyKJku9LKUrQgD6IG2lT5YiMt7wQLVCF0/c
kkLpMKGevrndym/RlcfzuR5uMlj8I7dxmiRmQOWV22oQLASOc4WtKZzb90pu6rtb
gE/0ir+y89BoI10ZG1oc
=/Ygm
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org