Mailing-List: contact httpclient-users-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpClient User Discussion" <httpclient-users@hc.apache.org>
MIME-Version: 1.0
In-Reply-To: <1464978073.4082.1.camel@apache.org>
References: <CAD77Uj4ByWtA3s_5XyPTu-Qi86rG5sbq1hX90VyOdXRj9x91Zw@mail.gmail.com>
 <1464978073.4082.1.camel@apache.org>
From: Benson Margulies <bimargulies@gmail.com>
Date: Fri, 3 Jun 2016 15:49:39 -0400
Message-ID: <CALhtWkeK6bTqJ_ibj2kX2CHLHRL_U+qb1v9NN6oPWsmy8qztbA@mail.gmail.com>
Subject: Re: Multipart Mixed
To: HttpClient User Discussion <httpclient-users@hc.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 03 Jun 2016 19:49:50 -0000

Here's what I coded. It's not a patch, just code you're welcome to,
but it's probably much like yours.

private void setupMultipartRequest(final DocumentRequest request,
final ObjectWriter finalWriter, HttpPost post) {

    MultipartEntityBuilder builder =3D MultipartEntityBuilder.create();
    builder.setMimeSubtype("mixed");
    builder.setMode(HttpMultipartMode.STRICT);

    FormBodyPartBuilder partBuilder =3D FormBodyPartBuilder.create("request=
",
            // Make sure we're not mislead by someone who puts a
charset into the mime type.
            new
AbstractContentBody(ContentType.parse(ContentType.APPLICATION_JSON.getMimeT=
ype()))
{
                @Override
                public String getFilename() {
                    return null;
                }

                @Override
                public void writeTo(OutputStream out) throws IOException {
                    finalWriter.writeValue(out, request);
                }

                @Override
                public String getTransferEncoding() {
                    return MIME.ENC_BINARY;
                }

                @Override
                public long getContentLength() {
                    return -1;
                }
            });

    // Either one of 'name=3D' or 'Content-ID' would be enough.
    partBuilder.setField(MIME.CONTENT_DISPOSITION, "inline;name=3D\"request=
\"");
    partBuilder.setField("Content-ID", "request");

    builder.addPart(partBuilder.build());

    partBuilder =3D FormBodyPartBuilder.create("content", new
InputStreamBody(request.getContentBytes(),
ContentType.parse(request.getContentType())));
    partBuilder.setField(MIME.CONTENT_DISPOSITION, "inline;name=3D\"content=
\"");
    partBuilder.setField("Content-ID", "content");
    builder.addPart(partBuilder.build());
    builder.setCharset(StandardCharsets.UTF_8);

    HttpEntity entity =3D builder.build();
    post.setEntity(entity);
}


On Fri, Jun 3, 2016 at 2:21 PM, Oleg Kalnichevski <olegk@apache.org> wrote:
> On Thu, 2016-06-02 at 12:52 +0200, Stefan Magnus Landr=C3=B8 wrote:
>> Hi there,
>>
>> We're struggeling with some limitations in the current multipart
>> implementation in 4.5 (latest).
>>
>> The MultipartEntityBuilder is actually building a MultipartFormEntity,
>> whereas we actually want to be able to build a multipart/mixed entity wh=
ich
>> does have limitations with respect to filesize as defined in
>> MultipartFormEntity.
>>
>> We're considering improving the MultipartEntityBuilder in such a way tha=
t
>> it can also produce MultipartMixedEntity (new type)
>>
>> Oleg, any comments?
>>
>
> Stefan
>
> I am not sure I fully understand the issue but you are welcome to submit
> a patch with changes you deem necessary.
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> For additional commands, e-mail: httpclient-users-help@hc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org