Mailing-List: contact httpclient-users-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpClient User Discussion" <httpclient-users@hc.apache.org>
MIME-Version: 1.0
In-Reply-To: <57077e04.839a1c0a.67c51.ffffb1af@mx.google.com>
References: 
 <CABrquLxD_9hDTJOKyNiKi5N8f_pV5M5XQWc+9icDkDLTZFy_ag@mail.gmail.com>
 <57077e04.839a1c0a.67c51.ffffb1af@mx.google.com>
From: Tim Webster <tim.webster@gmail.com>
Date: Fri, 8 Apr 2016 11:02:09 +0100
Message-ID: 
 <CABrquLyqqzWJZwn7H+ROmyN7_XOE8-78Q0ipSXq8HE29FFNE=w@mail.gmail.com>
Subject: Re: releasing streamed connections back to connection pool
To: Bernd Eckenfels <ecki@zusammenkunft.net>
Cc: "httpclient-users@hc.apache.org" <httpclient-users@hc.apache.org>
Content-Type: multipart/alternative; boundary=001a1142a4d2e8e5be052ff64aeb

--001a1142a4d2e8e5be052ff64aeb
Content-Type: text/plain; charset=UTF-8

OK...so do you think I need to use this class to explicitly to consume the
response?  I can see some methods on there for this.

Also - I think the call to PostMethod.releaseConnection() will still close
it - do you have any idea if this should / should not be used?

Thanks,


On Fri, Apr 8, 2016 at 10:46 AM, Bernd Eckenfels <ecki@zusammenkunft.net>
wrote:

> It looks like the HttpResponseProxy will be responsible for releasing the
> connection once the entity is consumed. Most likely by wrapping and
> tracking the input stream.
>
>
>
>
> Gruss
> Bernd
> --
> http://bernd.eckenfels.net
> From Win 10 Mobile
>
>
>
> *Von: *Tim Webster <tim.webster@gmail.com>
> *Gesendet: *Freitag, 8. April 2016 11:42
> *An: *httpclient-users@hc.apache.org
> *Betreff: *releasing streamed connections back to connection pool
>
>
>
> Hi,
>
>
>
> I'm using Spring's HttpComponentsHttpInvokerRequestExecutor in my
>
> application, configured with a PoolingHttpClientConnectionManager.
>
>
>
> It all works fine, except that when a request is executed, the HTTP
>
> connection that was used is closed after every request.  This is a result
>
> of Spring calling HttpPost.releaseConnection().
>
>
>
> Ideally the connections would not be closed, but just released back to the
>
> connection pool.   This is especially important for HTTPS connections and
>
> the overhead of handshakes.
>
>
>
> My problem is, when httpPost.releaseConnection() is called, instead of just
>
> releasing the connection back to the pool, it closes it.  If you dig into
>
> the code you can see it ends up calling ConnectionHolder.cancel(), where
>
> ideally it would be calling ConnectionHolder.releaseConnection().
>
>
>
> I thought I could override the Spring code to NOT call
>
> HttpPost.releaseConnection(), figuring the connection manager would take
>
> care of releasing the connection itself, which it does, but not in my case
>
> because it is a streaming request (these are HTTP posts with input stream):
>
>
>
> From MainClientExec.java:
>
>
>
>
>
>             // check for entity, release connection if possible
>
>             final HttpEntity entity = response.getEntity();
>
>            if (entity == null || !entity.isStreaming()) {
>
>                 // connection not needed and (assumed to be) in re-usable
>
> state
>
>                 connHolder.releaseConnection();
>
>                 return new HttpResponseProxy(response, null);
>
>             } else {
>
>                 return new HttpResponseProxy(response, connHolder);
>
>             }
>
>
>
> So - I don't see a way with the API the way it is to do what I require,
>
> which is release the connection (without closing it) after consuming the
>
> response.
>
>
>
> I'm happy to provide more details/context if anyone can help....
>
>
>
> thanks,
>
>
>

--001a1142a4d2e8e5be052ff64aeb--