hc-httpclient-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: httpClient.getConnectionManager() performance with HTTP only
Date Wed, 17 Feb 2016 18:47:10 GMT
Hello,
I think I have fixed the issue in JMeter, I attached patch to:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=58099

Reviews and feedback very welcome.
Regards

On Tue, Jan 5, 2016 at 3:05 PM, sebb <sebbaz@gmail.com> wrote:

> On 22 December 2015 at 08:36, Oleg Kalnichevski <olegk@apache.org> wrote:
> > On Sun, 2015-12-20 at 22:44 +0100, Philippe Mouawad wrote:
> >> Hi Oleg,
> >> Back to this old subject and knowing that we must stick to 1 HttpClient
> per
> >> thread (as per all the discussion that followed this).
> >> Is there a plan to implement this lazy init of SSLContext in HttpClient
> as
> >> it used to be the case in HC3 ?
> >>
> >> For our project, it's a killer in terms of performance, and for other
> use
> >> cases, it appears kind of weird that an SSLContext is initialized even
> for
> >> a pure HTTP traffic.
> >>
> >
> > Given that HttpClient instance should be initialized only once, eager
> > initialization of the SSLContext looks reasonable to me.
>
> AFAICT there are lots of ways to configure the HttpClient instance by
> using HttpClientBuilder or HttpClients.
> So I don't understand why you say that the HttpClient instance should
> only be initialised once.
>
> > One, of course, can make SSL initialization lazy by using a custom
> > connection socket factory with SSLContext initialized on demand.
> >
> > Hope this helps
> >
> > Oleg
> >
> >> Thanks
> >> Regards
> >>
> >>
> >>
> >> On Thu, May 15, 2014 at 10:39 AM, Oleg Kalnichevski <olegk@apache.org>
> >> wrote:
> >>
> >> > On Wed, 2014-05-14 at 19:46 +0100, sebb wrote:
> >> > > On 14 May 2014 12:28, Oleg Kalnichevski <olegk@apache.org> wrote:
> >> >
> >> > ...
> >> >
> >> > > >> Issue is not present in HTTPCLient 3.1
> >> > > >
> >> > > > Philippe
> >> > > >
> >> > > > If HttpClient is used correctly, this code should only be
> executed only
> >> > > > once. Why does JMeter create more than one instance of HttpClient?
> >> > >
> >> > > We currently create an instance for each instance of different proxy
> >> > > settings and each protocol and each authority, because the client
is
> >> > > created with these settings.
> >> > >
> >> > > This is also done for each thread.
> >> > >
> >> > > IIRC, this was necessary originally. We have not rewritten the code
> >> > > yet to use all the latest features.
> >> > >
> >> >
> >> > I see. For the time what you can do is to use a custom SSL socket
> >> > factory that lazily initializes SSL context when requested for the
> first
> >> > time. This is exactly what HC 3.1 does. It will be somewhat slower
> given
> >> > that one would need to mutex to synchronize access to the
> initialization
> >> > code.
> >> >
> >> > Oleg
> >> >
> >> > > > Oleg
> >> > > >
> >> > >
> >> > >
> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> >> > > For additional commands, e-mail:
> httpclient-users-help@hc.apache.org
> >> > >
> >> >
> >> >
> >> >
> >>
> >>
> >
> >
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message