Return-Path: X-Original-To: apmail-hc-httpclient-users-archive@www.apache.org Delivered-To: apmail-hc-httpclient-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1169C18356 for ; Sun, 13 Dec 2015 20:30:44 +0000 (UTC) Received: (qmail 88448 invoked by uid 500); 13 Dec 2015 20:30:43 -0000 Delivered-To: apmail-hc-httpclient-users-archive@hc.apache.org Received: (qmail 88382 invoked by uid 500); 13 Dec 2015 20:30:43 -0000 Mailing-List: contact httpclient-users-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpClient User Discussion" Delivered-To: mailing list httpclient-users@hc.apache.org Received: (qmail 88370 invoked by uid 99); 13 Dec 2015 20:30:43 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Dec 2015 20:30:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A7F77C0BCA for ; Sun, 13 Dec 2015 20:30:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.88 X-Spam-Level: ** X-Spam-Status: No, score=2.88 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id TkjC_Y74YYf0 for ; Sun, 13 Dec 2015 20:30:37 +0000 (UTC) Received: from mail-ig0-f169.google.com (mail-ig0-f169.google.com [209.85.213.169]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 2EC0526638 for ; Sun, 13 Dec 2015 20:30:37 +0000 (UTC) Received: by mail-ig0-f169.google.com with SMTP id su19so71100870igc.0 for ; Sun, 13 Dec 2015 12:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=A6PZrhbhn1GWd7dz71qzdMslDkdjZ6mlxMe71F7lUKw=; b=TYhBnYdhY3VHWXO4PbqRfRNr/JzPK/2M5h+hFV+LlhsS61eyTNVg6WjcVDs5pvsZOp 9OB1HORpXaTXNBXecfBzzEGkY7ja2f1h5BUi8ka3kAHsaVsfY2b3PNTxB+a4nvJTg/eN wuOTBqb3u1VRHLEkbX6xUOfyS0QujwrIlAqvJ0bqNKS73ei2Ivd2fBZoVOovMlWNCymA +rpGLqQ7GqP8IWQRztk5vX/uhdArIGYt+UAXU/Ya15DwRVAR3q4pkcVWxBX//FwJxKAz wY68LY1J8bZQC1lOw84Ql8USESJVBBmsUFzB2R2WZH+3z7G5zrTrQ1ZJ/po9Qb3dN8G9 +DDg== MIME-Version: 1.0 X-Received: by 10.50.64.178 with SMTP id p18mr13972331igs.57.1450038636535; Sun, 13 Dec 2015 12:30:36 -0800 (PST) Received: by 10.107.51.5 with HTTP; Sun, 13 Dec 2015 12:30:36 -0800 (PST) In-Reply-To: <1449318418.12301.4.camel@apache.org> References: <1449066992.12071.17.camel@apache.org> <1449068437.12071.23.camel@apache.org> <1449318418.12301.4.camel@apache.org> Date: Sun, 13 Dec 2015 21:30:36 +0100 Message-ID: Subject: Re: Issues when upgrading from 3 to 4.2.6 or 4.5.1 From: Philippe Mouawad To: HttpClient User Discussion Cc: "dev@jmeter.apache.org" Content-Type: multipart/alternative; boundary=047d7bd75c3ad766450526cd6d79 --047d7bd75c3ad766450526cd6d79 Content-Type: text/plain; charset=UTF-8 Hi, I created https://issues.apache.org/jira/browse/HTTPCLIENT-1704 with JUnit test case so that you understand the difference we have. Regards On Sat, Dec 5, 2015 at 1:26 PM, Oleg Kalnichevski wrote: > On Fri, 2015-12-04 at 21:43 +0100, Philippe Mouawad wrote: > > Thanks Oleg. > > But look at > > > https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L368 > , > > it concerns IGNORE_POLICY > > > > I really think there is at least one bug. > > Regards > > > > Sure thing. All these issues may well be due to bugs in HC. Could you > please though reproduce them with unit tests that do not involve JMeter > specific code? > > Oleg > > > > On Wed, Dec 2, 2015 at 4:00 PM, Oleg Kalnichevski > wrote: > > > > > On Wed, 2015-12-02 at 15:51 +0100, Philippe Mouawad wrote: > > > > Hi Oleg, > > > > Thanks for answer. > > > > > > > > Find my answers inline. > > > > Regards > > > > > > > > On Wed, Dec 2, 2015 at 3:36 PM, Oleg Kalnichevski > > > wrote: > > > > > > > > > On Tue, 2015-12-01 at 22:09 +0100, Philippe Mouawad wrote: > > > > > > Hello, > > > > > > Any answer on this question ? > > > > > > Thanks > > > > > > Regards > > > > > > > > > > > > On Sun, Nov 15, 2015 at 8:39 PM, Philippe Mouawad < > > > > > > philippe.mouawad@gmail.com> wrote: > > > > > > > > > > > > > Hello, > > > > > > > We're in the process of migrating JMeter to last HttpClient > 4.5.1. > > > > > > > > > > > > > > We are now migrating the CookieManager to remove all deprecated > > > code. > > > > > > > To test this class, we had a JUNIT class : > > > > > > > > > > > > > > > > > > > > > > > https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java > > > > > > > > > > > > > > Before migration, it was still testing HC3 version. > > > > > > > So we first switched to HC4.23 and noticed some failures: > > > > > > > > > > > > > > > > > I am confused. Are you using HC 4.2.3 or HC 4.5.1? > > > > > > > > > > > > As I wrote, first we switched our JUnit tests to use HC4 > Implementation > > > of > > > > CookieHandler and used 4.2.3, we got some failures compared to HC3. > > > > > > > > Then we switched from HC 4.2.3 to HC 4.5.1 and got other failures all > > > > detailed in initial mail. > > > > > > > > > > > > What policy does > > > > > CookeManager use internally? > > > > > > > > > It depends on tests, you can see in the code that depending on test > > > method > > > > we set different Policy to test them. > > > > > > > > > > You ought to be using RFC6265 policy either in strict or relaxed mode > > > and nothing else. All other policies have been marked as obsolete and > > > have already been removed in 5.0 (trunk). > > > > > > Oleg > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org > > > For additional commands, e-mail: httpclient-users-help@hc.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org > For additional commands, e-mail: httpclient-users-help@hc.apache.org > > -- Cordialement. Philippe Mouawad. --047d7bd75c3ad766450526cd6d79--