hc-httpclient-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: About SNI support in HC4.5
Date Wed, 30 Dec 2015 14:04:17 GMT
Ok, I understand , thanks Oleg.
I was just thinking that if you had the fix in new layers, it would maybe
be easy to fix it in deprecated ones. But I agree it might be loss of time
on your side.

On our side, as migration to 4.5.2 is not that easy and will surely take
time, it would have been helpful.

Regards
Philippe

On Wed, Dec 30, 2015 at 10:43 AM, Oleg Kalnichevski <olegk@apache.org>
wrote:

> On Tue, 2015-12-29 at 09:22 +0100, Philippe Mouawad wrote:
> > Hello Oleg,
> > Thanks for answer.
> > Could you elaborate a bit more on your answer ?
> >
> > Also, is there a chance that you fix the issue also in deprecated code of
> > httpclient (org.apache.http.conn.ssl.SSLSocketFactory) or is it too
> complex
> > ?
> >
>
> I personally see no point in fixing non-critical bugs in deprecated
> code. This time can be better spent elsewhere. However I can commit a
> fix though if contributed.
>
> Oleg
>
>
> > Thanks
> >
> > On Wednesday, December 23, 2015, Oleg Kalnichevski <olegk@apache.org>
> wrote:
> >
> > > On Wed, 2015-12-23 at 14:30 +0100, Philippe Mouawad wrote:
> > > > Hi,
> > > > Any answer on the 1/ question ?
> > > > Thanks
> > > > Regards
> > > >
> > > > On Tue, Dec 22, 2015 at 2:39 PM, Philippe Mouawad <
> > > > philippe.mouawad@gmail.com <javascript:;>> wrote:
> > > >
> > > > > Hi,
> > > > > With further investigation, I answered to some of my questions.
> > > > >
> > > > > Regards
> > > > >
> > > > > On Mon, Dec 21, 2015 at 6:52 PM, Philippe Mouawad <
> > > > > philippe.mouawad@gmail.com <javascript:;>> wrote:
> > > > >
> > > > >> Hello,
> > > > >> Looking at:
> > > > >>
> > > > >>    - https://issues.apache.org/jira/browse/HTTPCLIENT-1119
> > > > >>
> > > > >>
> > > > >> 1/ It is not clear for me how the fix works if commit association
> is
> > > > >> correct:
> > > > >>
> > > > >>    -
> > > https://fisheye6.atlassian.com/changelog/httpcomponents?cs=1544769
> > > > >>
> > > > >> Is the fix about replacing:
> > > > >>
> > > > >> final SSLSocket sock = (SSLSocket)
> this.socketfactory.createSocket();
> > > > >>
> > > > >> with :
> > > > >> SocketFactory.getDefault().createSocket();
> > >
> > > Pretty much. Please note though that the use of a plain socket instead
> > > of a fully initialized SSL socket causes a different execution path in
> > > #connectSocket method.
> > >
> > > Oleg
> > >
> > >
> > >
> > >
> >
>
>
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message