hc-httpclient-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Issues when upgrading from 3 to 4.2.6 or 4.5.1
Date Sun, 15 Nov 2015 19:39:04 GMT
Hello,
We're in the process of migrating JMeter to last HttpClient 4.5.1.

We are now migrating the CookieManager to remove all deprecated code.
To test this class, we had a JUNIT class :
https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java

Before migration, it was still testing HC3 version.
So we first switched to HC4.23 and noticed some failures:

   -
   https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L168



   -
   https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L280

Not failing with last version

   -
   https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L367

It appears matches returns true for ignorepolicy, IMHO, it should not, it's
a change in behaviour

   -
   https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L314


Then we migrated to HC4.5.1 and noticed an additional failure on:

   -
   https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L76
   -
   https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L159

Are those changes related to changes in RFC6265 or are they regressions ?

I think this one is a regression:

https://github.com/ubikloadpack/jmeter/blob/HC4_5/test/src/org/apache/jmeter/protocol/http/control/TestCookieManager.java#L367

2 Failures (testCookies1, testCookies2) seem to be related to multiple
cookies parsing:

   - test1=1; comment=\"how,now\", test2=2; version=1
   - test1=1;secure, test2=2;secure

Reading section http://tools.ietf.org/html/rfc6265#section-5.2, I wonder if
multi values set cookie is allowed ?
-- 
Regards.
Philippe M.




-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message