Mailing-List: contact httpclient-users-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpClient User Discussion" <httpclient-users@hc.apache.org>
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Message-ID: <1391072941.5241.4.camel@ubuntu>
Subject: Re: Cancel and socket state
From: Oleg Kalnichevski <olegk@apache.org>
To: HttpClient User Discussion <httpclient-users@hc.apache.org>
Date: Thu, 30 Jan 2014 10:09:01 +0100
In-Reply-To: 
 <CAOioXJC-0N0J949z74vd4ZS4VjrvuHVEt9459LQRgnHy5xBiyg@mail.gmail.com>
References: 
	<CAOioXJAoQCtA_EiOxxQuXb1LyUU6G9BcgjcES8EwWcCm1ZHcTA@mail.gmail.com>
	 <1390985193.24336.1.camel@ubuntu>
	 <CAOioXJDg6xgV7wgiBVH618OJgLR-zZknA_tKwNV0LVionQ_WGg@mail.gmail.com>
	 <1390990185.24336.18.camel@ubuntu>
	 <CAOioXJDZ6PQ3mGgb6+zKNgxPdLJq__+Ew5ByqZ3=NbC0_cWbjg@mail.gmail.com>
	 <1391004263.24336.25.camel@ubuntu>
	 <CAOioXJApw5V+87a5exqic91JGn6GSTxBQcbsf2wQd3RUVcXhQQ@mail.gmail.com>
	 <1391012647.32684.3.camel@ubuntu>
	 <CAOioXJBF8FB_-wRdNzP6RAN9ZH+DVoASY=WnRQ5HHnZzjVTiMw@mail.gmail.com>
	 <26595f84-8167-4321-b523-ae819a755725@email.android.com>
	 <CAOioXJC-0N0J949z74vd4ZS4VjrvuHVEt9459LQRgnHy5xBiyg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Thu, 2014-01-30 at 09:49 +0100, Thomas Boniface wrote:
> In case I don't do the cancel the connection is released and only
> disconnected once the keep alive timeout is reached.
> 

This is a very important bit of information. I'll see if I can reproduce
the same behavior locally.

> I experience a file descriptor leak in my tomcat process and I was
> suspecting the request cancellation may be the source cause but it appears
> it does not as not canceling the request do not solve the issue. Though I
> was expecting that canceling the request would get the connection back in
> the pool sooner that letting the request I don't need anymore finish.
> 

Please note that if an HTTP exchange cannot be fully completed the
underlying connection is simply unsafe to re-use and needs to be
discarded.

Oleg

> I will try to reproduce my leak issue in a simpler context.
> 
> Thomas
> 
> 
> 2014-01-29 Oleg Kalnichevski <olegk@apache.org>:
> 
> > On January 29, 2014 5:38:13 PM CET, Thomas Boniface <thomas@stickyads.tv>
> > wrote:
> > >Thanks for your help regarding the snapshot. Here is an updated log
> > >using
> > >the 4.0.1-SNAPSHOT.
> > >
> > >Regarding request cancel, it is done as follow:
> > >
> > >if (futureHttpResponse != null && !futureHttpResponse.isCancelled()) {
> > >            futureHttpResponse.cancel(true);
> > >}
> > >
> > >where futureHttpResponse  what the object return by the execute call.
> > >
> > >Thomas
> >
> > Thomas,
> > I am sorry I cannot reduce the cause of the problem just by looking at the
> > log.
> >
> > What happens if you do not cancel the request? Does the connection get
> > returned to the pool?
> >
> > Oleg
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> > For additional commands, e-mail: httpclient-users-help@hc.apache.org
> >
> >


---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org