hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1883) Add https.proxy* documentation to HttpClientBuilder
Date Thu, 23 Nov 2017 12:44:00 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264274#comment-16264274

Oleg Kalnichevski commented on HTTPCLIENT-1883:

We happily take patches or PR at GitHub


> Add https.proxy* documentation to HttpClientBuilder
> ---------------------------------------------------
>                 Key: HTTPCLIENT-1883
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1883
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.5.3
>            Reporter: Marcel Stör
>              Labels: documentation
> To amend HTTPCLIENT-1128 I guess...
> I find the list of [{{http.proxy*}} system properties in the type Javadoc for {{HttpClientBuilder}}|https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L140]
a bit misleading.
> The JVM distinguishes between HTTP and HTTPS proxy settings (decide for yourself how
much sense that makes) but the Javadoc comment only talks about {{http.proxy*}} system properties
and not {{https.proxy*}} system properties. One might come to the conclusion that by using
{{#useSystemProperties()}} on the builder you'd only get proxy support for HTTP connections
but not for HTTPS. 
> Adding a short note about that would be appropriate IMO.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message